871416 - Support any size of video frame in WebRTC PeerConnections

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Currently the code in MediaPipelineTransmit::PipelineListener::ProcessVideoChunk assumes at least that video frame sizes must be even. If they're not I think we just crash. (I tried writing a testcase but I couldn't quickly find a suitably odd-sized video.)

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

There's a reason you can't find odd-pixel videos.... ;-)  But they may exist.

A patch that's been waiting on reviews since late Feb adds asserts that sizes  in SendVideoFrame() are even.

However: since the GIPS API doesn't include 'stride', we can't change the width or height of a video without copying it.  So this can't be supported currently without at least filtering off the odd pixel inside the GIPS code.  Tim can talk to whether the video codecs (and all the other video code in GIPS/libyuv/etc) themselves would allow odd sizes instead of stripping the odd pixel.

Comment 2

[Timothy B. Terriberry (:derf)]

(In reply to Randell Jesup [:jesup] from comment #1)
> Tim can talk to whether the video codecs (and all the other video code in
> GIPS/libyuv/etc) themselves would allow odd sizes instead of stripping the
> odd pixel.

The codecs certainly do. I'd have to look to see what the state of libyuv support is.