Closed Bug 871514 Opened 6 years ago Closed 6 years ago

Replace "click" with "touch" on About:firefox update button

Categories

(Firefox for Android :: Theme and Visual Design, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 24

People

(Reporter: ibarlow, Assigned: stully)

Details

(Whiteboard: [mentor=kats][good first bug])

Attachments

(1 file, 1 obsolete file)

When tapping the "check for updates button", the string that comes back reads

"Update available; click to download"
or
"Update available; click to install"

We shouldn't be using the word "click" on Android, let's change it to "tap".
This was added in bug 827347 because there is no concept of tapping on Ouya.
Ah, I was wondering what brought about the change... Can we special case the Ouya builds, then so that they don't affect devices with touch screens?
Updating title -- for consistency with our updater we should use touch, not tap.
Summary: Replace "click" with "tap" on About:firefox update button → Replace "click" with "touch" on About:firefox update button
I want to give Kats a chance to respond since he championed the change. I do think Ouya has a touchpad on the controller, so "touch" or "tap" might not be as foreign to those users.
While the Ouya controller does have a touchpad, it is used to control a mouse cursor that appears on the screen, so I think using "click" is the most appropriate for that scenario. Using "tap" might be ok there too, but "touch" doesn't feel right for that scenario. If we absolutely want to use "touch" or "tap" for touch-enabled devices I'm not opposed to special-casing this.
Hm, or we could just change the string everywhere to read "Download update" when one is available
That sounds good to me. There's another message that shows up after the update is downloaded that says "Updated downloaded; click to install" - I assume we should change that to "Install update" as well.
Trivial string changes make for good first bugs :) The strings are located in mobile/android/locales/en-US/chrome/about.dtd.
OS: Mac OS X → Android
Hardware: x86 → All
Whiteboard: [mentor=kats][good first bug]
Hi,
I'd like to get involved with FireFox Mobile, figure this would be a good first bug.  Mind if I assign this one to myself?
(In reply to alexchan7432 from comment #9)
> Hi,
> I'd like to get involved with FireFox Mobile, figure this would be a good
> first bug.  Mind if I assign this one to myself?

Go ahead. For some information on building Firefox on Android, see:
https://wiki.mozilla.org/Mobile/Fennec/Android

For realtime chatting with other developers, visit #mobile on Mozilla's IRC server:
http://irc.mozilla.org
Assignee: nobody → stully
Changed updates available and updates downloaded strings as described in comments.
Attachment #752955 - Flags: review?(bugmail.mozilla)
Comment on attachment 752955 [details] [diff] [review]
change strings as described in comments

Review of attachment 752955 [details] [diff] [review]:
-----------------------------------------------------------------

After double-checking the string change procedure [1] (I haven't had to do this very often) it looks like we'll have to update the entity names as well. So for example you can change aboutPage.checkForUpdates.available to aboutPage.checkForUpdates.available2 in the dtd file and update the references to it in about.xhtml as well.

Also please make sure your patch includes a commit message as per [2]

[1] https://developer.mozilla.org/en-US/docs/Making_String_Changes
[2] https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Attachment #752955 - Flags: review?(bugmail.mozilla) → review-
Attachment #752955 - Attachment is obsolete: true
Change string entity names and reflect changes in about.xhtml (and added commit message; sorry!)
Attachment #752996 - Flags: review?(bugmail.mozilla)
Comment on attachment 752996 [details] [diff] [review]
02 Remove "click" from update strings to accomodate touch devices

Review of attachment 752996 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #752996 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/48b38e667074
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
You need to log in before you can comment on or make changes to this bug.