Open Bug 871538 Opened 8 years ago Updated 8 years ago

Some extensions that are installed with repack builds are not kept if Firefox is opened with older profiles

Categories

(Firefox :: General, defect)

21 Branch
x86
All
defect
Not set
normal

Tracking

()

Tracking Status
firefox21 - affected

People

(Reporter: simona.marcu, Unassigned)

Details

(Keywords: regression)

Mozilla/5.0 (Windows NT 5.1; rv:21.0) Gecko/20100101 Firefox/21.0
Build ID: 20130512144307

Prerequisites: Create at least one profile and open it with a normal Firefox build (not a repack one).

Steps to reproduce:
1. Download and install Firefox repacked with Mail.ru from: 
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/19.0-candidates/build1/partner-repacks/mail.ru/
2. Create a new profile and start the newly installed Firefox (Mozilla Firefox for Mail.Ru)
3. Close Firefox
4. Launch Firefox again but open it with an older profile.

Expected results:
The extension installed with the repack build is present in the extensions list in the Add-on manager.

Actual results:
The extension installed with the repack build is not present in the Add-on Manager (it should be considering the fact that the extension is in the distribution folder).

Note:
The issue is reproducible also with other repack builds - AOL for example.
The issue is not reproducible on  Firefox 20 for Mail.ru.
The issue is not reproducible on Mac OS X and on Ubuntu - the issue is Windows only.
(In reply to Simona B [QA] from comment #0)
> Note:
> The issue is reproducible also with other repack builds - AOL for example.
> The issue is not reproducible on  Firefox 20 for Mail.ru.
> The issue is not reproducible on Mac OS X and on Ubuntu - the issue is
> Windows only.

That would seem to indicate this as a regression in Firefox 21. We'll need to prioritize finding a regression window to see if this is fallout from our work in bug 842334.
Actually, wait, I might be reading this wrong. Your comment seems to indicate this reproduces with Mail.ru 21 and Mail.ru 19, but not with Mail.ru 20?
I just tried to reproduce this and could not.

1. Install the latest mozilla-central build and start with a new Nightly profile then quit
2. Install Firefox 19 for Mail.ru and start with a new Mail.ru profile then quit
3. Start Firefox 19 for Mail.ru again but this time with the Nightly profile

In both circumstances the Mail.ru extension is intact.

Can you please provide more information to reproduce this issue? Dropping this down to unconfirmed until we have confirmable steps to reproduce.
Status: NEW → UNCONFIRMED
Ever confirmed: false
Keywords: steps-wanted
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #2)
> Actually, wait, I might be reading this wrong. Your comment seems to
> indicate this reproduces with Mail.ru 21 and Mail.ru 19, but not with
> Mail.ru 20?

Sorry for that. Somehow I got lost in the opened tabs and I pasted the link for Firefox 19 with Mail.ru instead of the one for Firefox 21. 
The issue is reproducible on Firefox 21 with Mail.ru and is not reproducible on Firefox 19 with Mail.ru.
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #3)
> I just tried to reproduce this and could not.
> 
> 1. Install the latest mozilla-central build and start with a new Nightly
> profile then quit
> 2. Install Firefox 19 for Mail.ru and start with a new Mail.ru profile then
> quit
> 3. Start Firefox 19 for Mail.ru again but this time with the Nightly profile
> 
> In both circumstances the Mail.ru extension is intact.
> 
> Can you please provide more information to reproduce this issue? Dropping
> this down to unconfirmed until we have confirmable steps to reproduce.

After further investigation I reached the conclusion that the issue is not reproducible with the latest mozilla central, nor the latest aurora. The issue is reproducible if the used profile is created on Firefox 21 RC or on Firefox 21 beta 7.

Last good build: Firefox 21 beta 6
First bad build: Firefox 21 beta 7
Pushlog: http://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=c1453860aef9&tochange=0fe6378ac802

Please see the screencast for more details: http://screencast.com/t/OWOZCNlg
Status: UNCONFIRMED → NEW
Ever confirmed: true
Looking at your screencast I'm seeing some inconsistent behavior that I want confirmed from someone who knows more about these partner builds. Your steps to reproduce are a little more involved that what you originally indicated.

1. Install Firefox 21build3 and start with a new profile
2. Quit Firefox then install Mail.ru 21 and start with a new profile
3. Quit Firefox Mail.ru and start Firefox 21build3 with the profile from step 1

Based on those steps I would not expect any of the partner stuff to exist in the non-partner build using the non-partner profile but it appears that this is not the case. So I would actually flip this bug around to mean "Installing a partner build makes modifications to non-partner build/profile".

FWIW, I see nothing in that changeset to indicate a regression was introduced and I still can't reproduce this even with following precisely what your screencast shows. Lets leave this unconfirmed until we have confirmation that someone other than yourself can reproduce this on some other system.

Alex, could you find someone who has more expertise on these partner builds to comment?
Status: NEW → UNCONFIRMED
Ever confirmed: false
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #6)
> Looking at your screencast I'm seeing some inconsistent behavior that I want
> confirmed from someone who knows more about these partner builds. Your steps
> to reproduce are a little more involved that what you originally indicated.
> 
> 1. Install Firefox 21build3 and start with a new profile
> 2. Quit Firefox then install Mail.ru 21 and start with a new profile
> 3. Quit Firefox Mail.ru and start Firefox 21build3 with the profile from
> step 1

Indeed, in step 3 I Quit Firefox Mail.ru but I open the same Firefox Mail.ru with the profile from step 1 (not Firefox 21build3).
If instead of using Firefox 21build3 I use Firefox 21 beta 6 the issue is not reproducible.

Just to be sure - these are the STR used in the screencast from Comment 5:
1. Install Firefox 21build3
2. Install Firefox 21 Mail.ru
3. Launch Firefox 21buil3 with a new profile (RC profile).
4. Close Firefox 21build3.
5. Launch Firefox 21 Mail.ru with a new profile (Mail.ru profile) and look over the extensions from the Add-ons Manager
--> the extension that was installed with the build (@Mail.Ru 2.5.3.30) is present
6. Close Firefox 21 Mail.ru 
7. Start Firefox 21 Mail.ru again but use the profile from step 1 (the RC profile) and look over the extensions list
--> the extention that was installed with the repack build is not there.

Please make sure to use a Windows machine when trying to reproduce the issue.
I had to alter your steps a bit to not use the default install folder since both 21build3 and 21 Mail.ru default to the same folder.

1. Install Firefox 21.0build3 to C:\Program Files\Mozilla Firefox\ (default)
2. Install Mail.ru 21.0build3 to C:\Program Files\Mozilla Firefox Mail.ru\
3. Start Firefox 21build3 creating a new "RC User" profile
4. Quit Firefox 21build3
5. Start Mail.ru 21build3 creating a new "Mail.ru User" profile
6. Open the Addons Manager and look for the Mail.ru add-on
> @Mail.ru 2.5.3.30 is installed
7. Quit Mail.ru 21build3
8. Start Mail.ru 21build3 with the "RC User" profile
9. Open the Addons Manager and look for the Mail.ru add-on
> @Mail.ru 2.5.3.30 is NOT installed

Looking a bit deeper I can see that the Mail.ru profile has an extensions folder containing the Mail.ru add-on, the RC User profile does not.

It seems as though all the changes being made by Firefox Mail.ru's distribution.ini are carried over to the RC User profile except for the extension. Perhaps it's not loading the extension because it fails to find it in the user's profile folder.

A developer more familiar with how this works will need to comment as to whether this is expected or not.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Note that this does not reproduce if the test is repeated using Mail.ru 20.0 instead so it's possible something was regressed in Firefox 21 for this.

To clarify:
 * Mail.ru 20.0 -> unaffected
 * Mail.ru 21.0#3 -> affected
 * Mail.ru 21.0#1 -> affected

As such I do not think this is a regression caused by bug 842334.
It's worth pointing out that both Firefox 20 and 21 come bundled with Mail.ru 2.5.3.30.
One final point, as a work around, if I do a pave-over install of Mail.ru 21 and start with the same profile this seems to fix it.
Note that this is not unique to Mail.ru, I tried a handful of different repacks and they all behave the same.
In terms of how real-world this situation is I'm not sure how common it would be. A user installing a partner build for the first time would not see this issue. A user updating from a previous partner repack would not see this issue. However, a user choosing to switch from Firefox 21 to a Firefox 21 repack would likely see this issue.
Profile switching issue, so wouldn't be a common problem (or a tracked issue). Please renominate if we got that wrong.
yeah i believe its a bug somehow. 

To summarize this what i have seen
-> Installed Firefox Ru-Locale 21 Vanilla
-> Surfed for a few seconds with this install so that a profile is generated etc
-> Installed Firefox 21 Mail.ru
--> Mail.ru extension is not installed

However in the install.log is mentioned 

Created Directory: C:\Program Files\Mozilla Firefox\distribution\extensions\{37964A3C-4EE8-47b1-8321-34DE2C39BA4D}\chrome\skin\tabs
  Installed File: C:\Program Files\Mozilla Firefox\distribution\extensions\{37964A3C-4EE8-47b1-8321-34DE2C39BA4D}\chrome\skin\toolbar-logo.png
  I
and so on. 

Kev do you know how bad this bug is (i don't think its a expected case or so common real world case).
I also see a similar issue with the default search engine: if I open a Yahoo repacked build with an older profile (which was also used with a Bing repacked build having Bing as default search engine) the default engine is not Yahoo, but the one for the previous used build (i.e Bing). I think this issue is also related to this bug. Let me know if you want me to log a separate one for the search engine.
You need to log in before you can comment on or make changes to this bug.