Alignment problems in websocket channel

RESOLVED FIXED in mozilla24

Status

()

Core
Networking: WebSockets
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Martin Husemann, Assigned: Martin Husemann)

Tracking

Trunk
mozilla24
Sun
NetBSD
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 748823 [details] [diff] [review]
Use memcpy and properly aligned temporary variables instead of pointer casts with unclear alignment

There are a few dubious lhs pointer casts which may triger bus errors on alignment critical archtitectures. At least the last one (assignment of mask to the header) did actualy hit in testing on sparc64.

Attached patch fixes it by using temporary variables and memcpy.
Attachment #748823 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4539a7706881
https://hg.mozilla.org/mozilla-central/rev/4539a7706881
Assignee: nobody → martin
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.