871905 - Fix function mismatch of calling nsIMobileMessageCallback::NotifyMessageDeleted() in widget/android/AndroidBridge.cpp caused by Bug 771458

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

This issue is found on b2g18 try build https://tbpl.mozilla.org/?tree=Try&rev=63247141bf75, Build error on android platform with log [1].

This issue does not show up in m-c try build but should be fixed.

[1] https://tbpl.mozilla.org/php/getParsedLog.php?id=22926788&tree=Try#error0

Comment 1

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

This bug is follow up bug for leo+ bug 771458, and is required to successfully build on b2g18 branch, also prevent future build error on m-c.

Comment 2

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: WIP - Fix build error on android platform.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Please attach two try links, one for m-c, the other for b2g18 instead.  I had a try a minute before with WEBSMS_BACKEND enabled, but it shows more errors than you got.

Comment 4

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #3)
> Please attach two try links, one for m-c, the other for b2g18 instead.  I
> had a try a minute before with WEBSMS_BACKEND enabled, but it shows more
> errors than you got.

try for current m-c : https://tbpl.mozilla.org/?tree=Try&rev=ce92be92342d
try for patch on b2g : https://tbpl.mozilla.org/?tree=Try&rev=5b64fd9ac60e

Comment 5

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Another round
current m-c : https://tbpl.mozilla.org/?tree=Try&rev=e62a37d0981b
b2g with patches : https://tbpl.mozilla.org/?tree=Try&rev=bcda0389b1dc

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Clear leo?. Will be landed in m-c and directly integrated into b2g18 patch set in bug 771458.

Comment 7

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Fix build error on android platform.

Comment 8

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try : https://tbpl.mozilla.org/?tree=Try&rev=8c8fb2856328

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/projects/birch/rev/e4f4691407c2

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e4f4691407c2

I assume this'll get a leo? nom soon?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)
> I assume this'll get a leo? nom soon?

Nevermind, I see this was rolled into the b2g18 patches for bug 771458.