Last Comment Bug 871938 - Crash reporter strings should use a variable for vendor instead of hardcoding 'Mozilla'
: Crash reporter strings should use a variable for vendor instead of hardcoding...
Status: RESOLVED FIXED
[mentor=kats][lang=xml]
:
Product: Firefox for Android
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All Android
: -- trivial (vote)
: Firefox 24
Assigned To: Shane Tully (:stully:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-14 02:30 PDT by Sebastian Hengst [:aryx][:archaeopteryx]
Modified: 2013-05-30 09:10 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use &vendorShortName; in Crash Reporter strings rather than a hardcoded "Mozilla" (5.36 KB, patch)
2013-05-23 16:17 PDT, Shane Tully (:stully:
bugmail: review+
Details | Diff | Splinter Review

Description Sebastian Hengst [:aryx][:archaeopteryx] 2013-05-14 02:30:58 PDT
android_strings.dtd:
<!ENTITY  crash_send_report_message2 "Tell Mozilla about this crash so they can fix it">
<!ENTITY  crash_allow_contact "Allow Mozilla to contact me about this report">

'Mozilla' should be a variable (like in toolkit) instead of hardcoding it.
Comment 1 Kartikaya Gupta (email:kats@mozilla.com) 2013-05-21 13:38:10 PDT
This should be as simple as replacing "Mozilla" with "&vendorShortName;" in those two strings in mobile/android/base/locales/en-US/android_strings.dtd, and possibly renaming the entities so they get picked up for localization.
Comment 2 Shane Tully (:stully: 2013-05-23 16:17:42 PDT
Created attachment 753531 [details] [diff] [review]
Use &vendorShortName; in Crash Reporter strings rather than a hardcoded "Mozilla"

Replaced "Mozilla" with &vendorShortName; as described in comments and renamed entity names.
Comment 3 Ryan VanderMeulen [:RyanVM] 2013-05-29 17:40:05 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c1d109eccfb
Comment 4 Ryan VanderMeulen [:RyanVM] 2013-05-30 09:10:20 PDT
https://hg.mozilla.org/mozilla-central/rev/5c1d109eccfb

Note You need to log in before you can comment on or make changes to this bug.