The default bug view has changed. See this FAQ.

Crash reporter strings should use a variable for vendor instead of hardcoding 'Mozilla'

RESOLVED FIXED in Firefox 24

Status

()

Firefox for Android
General
--
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aryx, Assigned: stully)

Tracking

Trunk
Firefox 24
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=kats][lang=xml])

Attachments

(1 attachment)

android_strings.dtd:
<!ENTITY  crash_send_report_message2 "Tell Mozilla about this crash so they can fix it">
<!ENTITY  crash_allow_contact "Allow Mozilla to contact me about this report">

'Mozilla' should be a variable (like in toolkit) instead of hardcoding it.
This should be as simple as replacing "Mozilla" with "&vendorShortName;" in those two strings in mobile/android/base/locales/en-US/android_strings.dtd, and possibly renaming the entities so they get picked up for localization.
Whiteboard: [mentor=kats][lang=xml]
(Assignee)

Updated

4 years ago
Assignee: nobody → stully
(Assignee)

Comment 2

4 years ago
Created attachment 753531 [details] [diff] [review]
Use &vendorShortName; in Crash Reporter strings rather than a hardcoded "Mozilla"

Replaced "Mozilla" with &vendorShortName; as described in comments and renamed entity names.
Attachment #753531 - Flags: review?(bugmail.mozilla)
Attachment #753531 - Flags: review?(bugmail.mozilla) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c1d109eccfb
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5c1d109eccfb
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
You need to log in before you can comment on or make changes to this bug.