871939 - [Dialer] Cannot search contact number when number has addtional area or operator number

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[Leo]

1. Title : Cannot search contact number when number has area or operator number
2. Precondition : Saved contact // ex) 21113754
3. Tester's Action : Making a call "01021113754" (010 is operator number)
4. Detailed Symptom : Cannot search contact number
5. Expected : Can search contact number. In android case, android can search contact number
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train : Reproduce
8. Gaia Revision : d5f7b2d3f7acc04c35abda8b001262d8912f9dfe
9. Gecko Revision : 0ab3418551bfcefe1e14633f8f2b0422707a4c2f
10 Personal email id : [e-mail]

Comment 1

[bhavana bajaj [:bajaj]]

This looks more like a feature request.Needsinfo on Krishna to see if we are planning on supporting this before blocking on this

Comment 2

[Leo]

Brazil Scenario :

Minimum matching digits : 7 digits.

Matching algorithm : 

Step 1. Find the matching number same as the back of 7-digits number in contacts
Step 2. If device find several matching numbers, shows number that get the first contact found.

For example, receiving number is "21113754", and saving numbers are "121113754" and "221113754".

In this case, device can find these two numbers, but only show first contact found.(If "121113754" is found at first, show "121113754")

Finding numbers is difference in many cases(different name or other information)

This is not android scenario but Brazil scenario.

Comment 4

[Leo]

Attachment: Example of matching number

Should pass all case.

Comment 5

[Leo]

As discussed in San Diego work week marking this as leo+.

Comment 6

[Andreas Gal :gal]

90 and 9090 are collect calls. We don't handle those in phonenumber.js. There are other bugs here as well, and a bunch of questions.

For example 87654321 should not match 01187654321 IMO. (11) is Sao Paulo but the number might be from a different city. I need some help from the leo team here understanding this.

Comment 7

[Leo]

I ask scenraio and I reply as soon as possible.

Comment 8

[Andreas Gal :gal]

I added support for parsing the national collect call (90) and I will post a patch shortly.

These are local numbers:

87654321
909087654321

987654321
9090987654321

Its not visible from the numbers that the current area code is 11 (Sao Paulo), so they can't match the other numbers. We could potentially do that by figuring out from the cell id/LAC that the cell tower is located in Sao Paulo. Is that what Android does here?

Comment 9

[Andreas Gal :gal]

I pushed a fix to phonenumber.js:

https://github.com/andreasgal/PhoneNumber.js/commit/8fb44b12b11baf7c3d1cd0ff3758701bcee71dee

This doesn't support 9090, since I don't know whether and how we will handle local calls. Waiting for leo feedback.

I will post a Gecko patch here.

Comment 10

[Andreas Gal :gal]

Attachment: patch, fixes everything except 9090 and local call area code inference

Comment 11

[Andreas Gal :gal]

Comment on attachment 755499 [details] [diff] [review]
patch, fixes everything except 9090 and local call area code inference

Gregor is out, so asking Etienne for help here.

Comment 12

[Andreas Gal :gal]

See the phonenumber.js changeset if you are curious what changes here.

The actual change is: (?:0|90), which makes us accept 90 in place of the national access number (0).

Comment 13

[Etienne Segonzac (:etienne)]

Comment on attachment 755499 [details] [diff] [review]
patch, fixes everything except 9090 and local call area code inference

Review of attachment 755499 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

Comment 14

[Andreas Gal :gal]

lets land this and clone the bug for the rest

Comment 15

[Andreas Gal :gal]

mwu, can you please land this? thanks

Comment 16

[Dale Harvey (:daleharvey)]

Issues with my repo access, switching back

Comment 17

[Michael Wu [:mwu]]

http://hg.mozilla.org/projects/birch/rev/f66d956d188e

Comment 18

[Michael Wu [:mwu]]

Apparently tbpl broke. Going to queue up so I can land as soon as it comes back up.

Comment 19

[Michael Wu [:mwu]]

This patch requires bug 875845 to apply cleanly to b2g18

Comment 20

[Michael Wu [:mwu]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/2d3a45c58878

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f66d956d188e

Comment 22

[Parul Mathur]

Added test case in MozTrap: 
https://moztrap.mozilla.org/manage/case/8503/

Comment 23

[sarsenyev]

The issue still reproduces on Leo 1.1 and Buri 1.2
Opened a new bug