871960 - b2g/chrome/content/content.css shouldn't use hard coded colours

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[Mounir Lamouri (:mounir)]

'color' properties in content.css should use system wide colours for text/background colours -moz-textField. That would allow customisation of the colours (like themes), make sure to pass reftests and would make a11y easier for visually impaired users (like having high contrast themes).

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

I can't find -moz-textField. Do you mean -moz-FieldText instead?

Comment 2

[Mounir Lamouri (:mounir)]

(In reply to jwwang from comment #1)
> I can't find -moz-textField. Do you mean -moz-FieldText instead?

Yes. -moz-Field and -moz-FieldText.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: replace hard coded colors with -moz-FieldText

Comment 4

[Mounir Lamouri (:mounir)]

Comment on attachment 752503 [details] [diff] [review]
replace hard coded colors with -moz-FieldText

Review of attachment 752503 [details] [diff] [review]:
-----------------------------------------------------------------

Given that layout/style/forms.css should already set the value of 'color' properties, I guess you can simply remove them. Also, you should ask :vingtetun for a revieew. This is directly affecting Gaia and he knows more than I do why those were hardcoded values.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: remove hard coded colors in content.css and duplicated definitions in forms.css

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 753086 [details] [diff] [review]
remove hard coded colors in content.css and duplicated definitions in forms.css

Given that this color naming scheme is not yet working I would like to see bug 849223 fixed first. 

Then defining those colors to #414141 in b2g/app/b2g.js would be nice too for this patch. r- because of this and the fact that it can't work without bug 849223.

I like the removal of the overridden colors.

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Btw, will this color extraction (from forms.css to content.css) fail if forms.css is running on some other platform where it doesn't inherit from b2g/chrome/content/content.css?

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Release the bug so someone can take it.

Comment 9

[BMO Automation]

Firefox OS is not being worked on