871985 - Make safe getter value descriptors more like regular data descriptors

Status: NEW

(DevTools :: Debugger, task, P5)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

In the remote debugging protocol a data descriptor looks like this:

"b": {
  "value": "beta",
  "enumerable": true,
  "configurable": false,
  "writable": true
}

Safe getter value descriptors however are currently like this:

"localName": {
  "getterValue": "p",
  "getterPrototypeLevel": 4,
  "enumerable": true,
  "writable": true
}

I propose that we make them look more like regular data descriptors, with a single additional property, |getterPrototypeLevel|:

"localName": {
  "value": "p",
  "enumerable": true,
  "configurable": true,
  "writable": true,
  "getterPrototypeLevel": 4
}

This has the benefit that client code doesn't have to handle these new descriptors specially, and displaying an object's properties in the traditional way is just a matter of merging the contents of |ownProperties| and |safeGetterValues|. It seems like adding |configurable| is a no-brainer and converting |getterValue| to |value| is net positive, since there is no ambiguity that this value was obtained by a getter (from the |getterPrototypeLevel| property and from the location of the descriptor inside the |safeGetterValues| dictionary.

Comment 1

[Brandon Benvie [:benvie]]

Perhaps presence of a setter can be used to determine writability as well.

Comment 2

[Jason Laster [:jlast]]

I believe this might have been fixed. CC nicolas.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

We still have the structure described in Comment 0 : devtools/server/actors/object.js#414-419