Closed Bug 872022 Opened 12 years ago Closed 12 years ago

don't link a review flag to splinter unless the attachment is a patch

Categories

(bugzilla.mozilla.org :: MyDashboard, defect)

Product:
bugzilla.mozilla.org
Component:
MyDashboard
Version:
Production
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: michiel, Assigned: dkl)

Details

Hopefully this is the right place for this bug, if not: apologies. In the webmaker.org components we attach github pull requests as attachments, filling in the pull URL as attachement text, and as description. This works well, it generates links when viewing the bug, but when an attachment gets a review request, or needinfo etc. flag, the links for these in the dashboard "flag" column don't actually go to anywhere real. For instance, https://bugzilla.mozilla.org/show_bug.cgi?id=871558 has a pull request attachment; when its review flag is set to '?' with me assigned, I will see this in my dashboard: Requester: ... Flag: review Bug: 871558 Updated: ... both flag and bug are links, the bug link works, but the flag link points to https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=871558&attachment=748977, which is a nonexistent thing.
Component: Extensions: ProductDashboard → Extensions: MyDashboard
Summary: links in the "flag" column generate "attachment error" pages → don't link a review flag to splinter unless the attachment is a patch
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2 modified extensions/MyDashboard/web/js/flags.js Committed revision 8800.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.