make jprof work with statically linked build

RESOLVED FIXED in mozilla0.9.3

Status

()

P3
normal
RESOLVED FIXED
17 years ago
10 years ago

People

(Reporter: waterson, Assigned: waterson)

Tracking

Trunk
mozilla0.9.3
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

17 years ago
We need to make some minor changes to get jprof working with the static build.
Since the jprof Makefile is a bit tangled, I think it's probably just easiest to
separate it into two parts: one that builds the stub that's linked into the main
executable, and one that builds the tool.

I propose that we create a subdirectory of mozilla/tools/jprof called ``stub'',
copy the following files in the repository, and then apply some changes to the
build system (which I'll attach momentarily)...

cd mozilla/tools/jprof
mkdir stub
cp libmalloc.h,v stub
cp libmalloc.cpp,v stub
cp jprof.h,v stub
cp config.h,v stub
(Assignee)

Updated

17 years ago
Blocks: 46775
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.3
(Assignee)

Comment 1

17 years ago
Created attachment 39603 [details]
mozilla/tools/jprof/stub/Makefile.in (new file)
(Assignee)

Comment 2

17 years ago
Created attachment 39604 [details] [diff] [review]
changes to build system
(Assignee)

Comment 3

17 years ago
jim, does this look okay to you?
(Assignee)

Updated

17 years ago
Keywords: patch

Comment 4

17 years ago
Looks like a good idea to me.

Comment 5

17 years ago
r=cls

Comment 6

17 years ago
file copying loving done.
and hey, why not sr=leaf while i'm at it?
sr=leaf for the new Makefile.in and build changes.
(Assignee)

Updated

17 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

17 years ago
Checked in.
Can we remove some of these files from their old locations?
(Assignee)

Comment 9

17 years ago
Oops, sorry. Done. 

Updated

10 years ago
Component: XP Miscellany → General
QA Contact: brendan → general
You need to log in before you can comment on or make changes to this bug.