872162 - Remove dead openURL function from web apps code, no longer check appOrigin in browser.js' onLocationChange

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (he/him)]

We check appOrigin to still disable chrome, but the only place that gets set is in web apps code which is no longer used. The caller was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=774216#c16 without removing the function itself. We should remove the function and remove our checks, and then remove the CSS for [disablechrome].

Comment 1

[:Gijs (he/him)]

Attachment: Patch

This should do the trick...

Comment 2

[:Gijs (he/him)]

Attachment: Remove CSS

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 749768 [details] [diff] [review]
Remove CSS

>   #main-window[sizemode=normal] #nav-bar[tabsontop=true],
>   #main-window[sizemode=normal] #nav-bar[tabsontop=true][collapsed=true]:not([customizing]) + toolbar,
>-  #main-window[sizemode=normal] #nav-bar[tabsontop=true][collapsed=true]:not([customizing]) + #customToolbars + #PersonalToolbar,
>-  #main-window[sizemode=normal][disablechrome] #navigator-toolbox[tabsontop=true]::after {
>+  #main-window[sizemode=normal] #nav-bar[tabsontop=true][collapsed=true]:not([customizing]) + #customToolbars + #PersonalToolbar {
>     border-top: 1px solid @toolbarShadowColor@;
>     border-top-left-radius: 2.5px;
>     border-top-right-radius: 2.5px;
>     background-clip: padding-box;
>   }

Can you file a bug on removing :not([customizing]), since collapsed toolbars aren't shown anymore while customizing?

Comment 4

[:Gijs (he/him)]

(In reply to Dão Gottwald [:dao] from comment #3)
> Can you file a bug on removing :not([customizing]), since collapsed toolbars
> aren't shown anymore while customizing?

Filed bug 872446.

Comment 5

[:Gijs (he/him)]

Both of these pushed to UX:
JS:  http://hg.mozilla.org/projects/ux/rev/4a4cb69ab494
CSS: http://hg.mozilla.org/projects/ux/rev/63ed2aa76f4d

Comment 6

[Matthew N. [:MattN]]

Can the JS(M)-only change also go to m-c? There was just a merge conflict from the patch since :marco is working on desktop app support again. I don't see a point in keeping dead code on m-c since it may become used again without notice and our merge will be harder.

Comment 7

[:Gijs (he/him)]

(In reply to Matthew N. [:MattN] from comment #6)
> Can the JS(M)-only change also go to m-c? There was just a merge conflict
> from the patch since :marco is working on desktop app support again. I don't
> see a point in keeping dead code on m-c since it may become used again
> without notice and our merge will be harder.

I believe so.

Comment 8

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/4a4cb69ab494
https://hg.mozilla.org/mozilla-central/rev/63ed2aa76f4d