872178 - UTF-8 encoding lost during ics roundtrip resulting in calendar read error (CAL_UTF8_DECODING_FAILED)

Status: RESOLVED FIXED

(Calendar :: ICAL.js Integration, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: testcase

When reading and writing a calendar file character information seems to be lost. Lightning fails to read the calendar file upon next startup. 

STR:
1. Set calendar.icaljs to true, restart Thunderbird
2. Use menu File > Open > Calendar File to subscribe to a local ics calendar file
3. Open the event that contains some special characters and just save it
4. Restart Thunderbird

Error:
Lightning fails to load the calendar file it has created in step 3.

Warning: There has been an error reading data for calendar: test. Error code: CAL_UTF8_DECODING_FAILED. Description: An error occured while decoding an iCalendar (ics) file as UTF-8. Check that the file, including symbols and accented letters, is encoded using the UTF-8 character encoding.

Comment 1

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v1

Looks like JS-only doesn't like using the string-input-stream. I've switched to an unicodeconverter stream, which seems to do the trick.

Comment 2

[Matthew Mecca [:mmecca]]

Comment on attachment 751446 [details] [diff] [review]
Fix - v1

r=mmecca

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central changeset c199fcb38e65