Closed Bug 87230 Opened 24 years ago Closed 24 years ago

should nsRuleNode be using jump tables instead of switch statements?

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED DUPLICATE of bug 87229

People

(Reporter: waterson, Assigned: waterson)

Details

dbaron and I were examining a jprof profile of an iBench run, and noticed that nsRuleNode::GetStyleData() appeared to have an inordinate amount of time spent _in the function_. There are two big inlined switch statements that degenerate to long, sequential test-and-jump runs of instructions. Perhaps using jump tables (specifically for the switch statement in nsRuleNode::GetStyleData, and the inlined nsCachedStyleData::GetStyleData() method) might improve this? I'll take a crack at hacking that up and see if it has any effect.
*** This bug has been marked as a duplicate of 87229 ***
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
vrfy
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.