Closed
Bug 872445
Opened 12 years ago
Closed 12 years ago
gaia-unit-tests TEST-UNEXPECTED-FAIL | Recipients List Recipients | expected undefined to be truthy
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(b2g18 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g18 | --- | fixed |
People
(Reporter: vingtetun, Assigned: julienw)
References
Details
Attachments
(1 file)
|
1.48 KB,
patch
|
gnarf
:
review+
|
Details | Diff | Splinter Review |
SMS tests are red. They need to be fixed.
|
Assignee | |
Comment 1•12 years ago
|
||
Note: this seems to be transient.
|
|
Assignee | |
Comment 2•12 years ago
|
||
I found the problem, taking it and a patch is coming.
Assignee: nobody → felash
|
|
Assignee | |
Comment 3•12 years ago
|
||
* removed the require for load_body_html_helper.js as we do it in setup.js now
* renamed the mocks helper to have a unique mocks helper var
---
apps/sms/test/unit/recipients_test.js | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
see also PR https://github.com/mozilla-b2g/gaia/pull/9789
Attachment #749840 -
Flags: review?(gnarf37)
|
|
Assignee | |
Comment 4•12 years ago
|
||
The PR makes Travis happy (for this test): https://travis-ci.org/mozilla-b2g/gaia/builds/7186202
|
||
Updated•12 years ago
|
Attachment #749840 -
Flags: review?(gnarf37) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
master: b38c84c0195b89688ed2cd525f23bb7297a55081
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•