Closed
Bug 872507
Opened 11 years ago
Closed 11 years ago
Tweak logcat java-exception regex to strip more whitespace
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
1.73 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
The current regex used for java exceptions results in superfluous tab characters partway through the TBPL compatible line: PROCESS-CRASH | java-exception | android.database.sqlite.SQLiteDiskIOException: error code 10: disk I/O error at android.database.sqlite.SQLiteStatement.native_execute(Native Method) (ie prior to the "at android.database.sqlite..."). This should fix that.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #749852 -
Flags: review?(jmaher)
Assignee | ||
Comment 2•11 years ago
|
||
Example log output: https://tbpl.mozilla.org/php/getParsedLog.php?id=22963296&full=1&branch=mozilla-inbound { 05-14 17:11:15.031 E/GeckoAppShell( 1809): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 9 ("GeckoBackgroundThread") 05-14 17:11:15.031 E/GeckoAppShell( 1809): android.database.sqlite.SQLiteDiskIOException: error code 10: disk I/O error 05-14 17:11:15.031 E/GeckoAppShell( 1809): at android.database.sqlite.SQLiteStatement.native_execute(Native Method) }
Comment 3•11 years ago
|
||
Comment on attachment 749852 [details] [diff] [review] Patch v1 Review of attachment 749852 [details] [diff] [review]: ----------------------------------------------------------------- regex's are evil and good at the same time.
Attachment #749852 -
Flags: review?(jmaher) → review+
Comment 4•11 years ago
|
||
Nice. Thanks!
Assignee | ||
Comment 5•11 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/a7bd66bbb68b
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a7bd66bbb68b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•