872557 - fix "enumeration value $X not handled in switch" warnings in HelpersSkia.h

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: fix "enumeration value $X not handled in switch" warnings in HelpersSkia.h

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 749890 [details] [diff] [review]
fix "enumeration value $X not handled in switch" warnings in HelpersSkia.h

It seems like this will hide useful warnings. What's the enumeration value that we're not handling.

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #2)
> It seems like this will hide useful warnings. What's the enumeration value
> that we're not handling.

Looks like FORMAT_R8G8B8A8, FORMAT_R8G8B8X8, FORMAT_YUV, and FORMAT_UNKNOWN.

FWIW, GfxFormatToGrConfig just below this function:

http://mxr.mozilla.org/mozilla-central/source/gfx/2d/HelpersSkia.h#43

was already using |default:|, so I figured it would be suitable to use |default:| in GfxFormatToSkiaConfig.

Comment 4

[Nathan Froyd [:froydnj]]

Pinging Jeff for a response to comment 3.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 749890 [details] [diff] [review]
fix "enumeration value $X not handled in switch" warnings in HelpersSkia.h

How about we do MOZ_ASSERT than if we have a format that we don't understand. It would be good to add this to the GfxFormatToGrConfig function too.

Comment 6

[Nathan Froyd [:froydnj]]

Attachment: fix "enumeration value $X not handled in switch" warnings in HelpersSkia.h

MOZ_ASSERTs added in the appropriate places.

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 770296 [details] [diff] [review]
fix "enumeration value $X not handled in switch" warnings in HelpersSkia.h

Looks like a recent skia update resolved the warning, but didn't add MOZ_ASSERTs.  I'm just going to cancel this review and close the bug, then.