Open
Bug 872626
Opened 11 years ago
Updated 2 years ago
Bad fcTL CRC in APNG files ignored (regression)
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
NEW
People
(Reporter: glennrp+bmo, Unassigned)
References
Details
Attachments
(2 files, 7 obsolete files)
|
1.52 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.50 KB,
patch
|
Details | Diff | Splinter Review |
The checkin of bug #857040 forced a regression of bug #397593. We should re-implement the patch in a way that only affects APNG datastreams, to reject datastreams that have fcTL or fdAt chunks with bad CRC as prior to the recent checkin.
|
Reporter | |
Comment 1•11 years ago
|
||
|
|
Reporter | |
Updated•11 years ago
|
|
||
Updated•11 years ago
|
|
|
Reporter | |
Comment 2•8 years ago
|
||
Rebased after recent changes to nsPNGDecoder.cpp
Attachment #749949 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 3•8 years ago
|
||
Relocate the png_set_crc_action(), use C++ style comment. Please submit to try.
Attachment #8776371 -
Attachment is obsolete: true
Flags: needinfo?(ryanvm)
|
||
Comment 4•8 years ago
|
||
Can we land a test for this too? https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6ec73db6e23
Flags: needinfo?(ryanvm) → in-testsuite?
|
|
Reporter | |
Comment 5•8 years ago
|
||
Comment on attachment 8776373 [details] [diff] [review] v02-872626-apng-bad-crc Try run was green. I'll provide a test case later.
Attachment #8776373 -
Flags: review?(jmuizelaar)
|
|
Reporter | |
Comment 6•8 years ago
|
||
Rebased and fixed indentation
Attachment #8776373 -
Attachment is obsolete: true
Attachment #8776373 -
Flags: review?(jmuizelaar)
Attachment #8777570 -
Flags: review?(jmuizelaar)
|
|
Reporter | |
Comment 7•8 years ago
|
||
Rebased and fixed indentation
Attachment #8777570 -
Attachment is obsolete: true
Attachment #8777570 -
Flags: review?(jmuizelaar)
Attachment #8777571 -
Flags: review?(jmuizelaar)
|
||
Comment 8•8 years ago
|
||
Comment on attachment 8777571 [details] [diff] [review] v03-872625-apng-bad-crc Review of attachment 8777571 [details] [diff] [review]: ----------------------------------------------------------------- Is it possible for us to get a test for this?
Attachment #8777571 -
Flags: review?(jmuizelaar) → review+
|
|
Reporter | |
Updated•8 years ago
|
Group: core-security
|
|
Reporter | |
Updated•8 years ago
|
Flags: needinfo?(abillings)
|
||
Updated•8 years ago
|
Flags: needinfo?(abillings)
|
|
Reporter | |
Comment 13•8 years ago
|
||
Rebased after landing bug #1240665
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8777571 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 15•8 years ago
|
||
Attachment #8778663 -
Attachment is obsolete: true
|
||
Updated•8 years ago
|
|
|
||
Updated•8 years ago
|
Group: core-security
|
|
Reporter | |
Comment 17•8 years ago
|
||
Flags: needinfo?(glennrp+bmo)
|
||
Comment 18•2 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.
Assignee: glennrp+bmo → nobody
Status: ASSIGNED → NEW
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•