Closed Bug 872649 Opened 9 years ago Closed 9 years ago

Pass MOZ_FRAMEPTR_FLAGS to the NSPR subconfigure

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla24

People

(Reporter: jseward, Assigned: jseward)

References

Details

Attachments

(1 file)

Patch
1.64 KB, patch
ted
: review+
Details | Diff | Splinter Review 
Without this, we won't get EXIDX unwind info on code in nspr, which
is a problem for ARM/Android profiling.
Attached patch Patch — — Splinter Review 
This also fixes a small bug Ted & I discussed on irc, in which
CPPFLAGS are temporarily stored in _SAVE_CPPFLAGS but then
restored from _SAVE_CFLAGS.  That didn't seem right.
Attachment #749982 - Flags: review?(ted)
Comment on attachment 749982 [details] [diff] [review]
Patch

Review of attachment 749982 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the cleanup!
Attachment #749982 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/b5e5bba18a44
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.