Pass MOZ_FRAMEPTR_FLAGS to the NSPR subconfigure

RESOLVED FIXED in mozilla24

Status

defect
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: jseward, Assigned: jseward)

Tracking

Trunk
mozilla24
ARM
Android
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

6 years ago
Without this, we won't get EXIDX unwind info on code in nspr, which
is a problem for ARM/Android profiling.
Assignee

Comment 1

6 years ago
Posted patch PatchSplinter Review
This also fixes a small bug Ted & I discussed on irc, in which
CPPFLAGS are temporarily stored in _SAVE_CPPFLAGS but then
restored from _SAVE_CFLAGS.  That didn't seem right.
Attachment #749982 - Flags: review?(ted)
Comment on attachment 749982 [details] [diff] [review]
Patch

Review of attachment 749982 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the cleanup!
Attachment #749982 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/b5e5bba18a44
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.