872754 - Follow-up: Combine Fragments/pre-Fragment layouts into a single pre-processed xml

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Through implementing multi-layer preference settings in bug 862116, we now have two sets of xml layout files to keep up to date. This is prone to errors/omissions.

The two sets of xml are necessary because we have to handle Fragments for tablets and (optionally v11+ phones) and pre-Fragments for pre-v11 phones; while the hierarchy is the same, the nesting code in layout has to specific either an Intent or a Fragment.

This should just basically be a single layout file that gets preprocessed into the correct Fragment/non-Fragment xml.

Comment 1

[Chenxia Liu [:liuche]]

It may also make more sense to have the different files in xml-v11/ and xml/, if Android handles that correctly. That would at least make it more obvious that changes need to be mirrored into different xml files.

Comment 2

[Chenxia Liu [:liuche]]

Re: comment 1: filed bug 873230 and added a patch.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.