872825 - Add Serbian keyboard entry to shared keyboard layouts list

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

The keyboard currently has two layouts for Serbian: sr-Cyrl (Cyrillic) and sr-Latn (Latin), however there is no Serbian ("sr") entry in shared/resources/keyboard_layouts.json, which is highly relevant for activating the keyboard layout associated with the current language in the FTU and Settings apps.

Moreover, given that the "Serbian (Cyrillic)" keyboard (sr-Cyrl) is included in the "cyrillic" keyboard layout group with the "Russian (Cyrillic)" keyboard (ru), and the "Serbian (Latin)" one (sr-Latn) is in an individual group ("serbian-latin"), a good approach would be to create a new layout group "serbian" that combines the Serbian layouts and update keyboard_layouts.json accordingly.

Comment 1

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Not sure if Serbian is in the target locales, Staś can you clarify this?

Comment 2

[Staś Małolepszy :stas]

Yes, Serbian is a target locale for Leo.

Comment 3

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #10008 - Add keyboard layout group for Serbian

Create new keyboard layout group for Serbian to include both latin ('sr-Latn') and cyrillic ('sr-Cyrl') keyboards for the language.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 754285 [details]
Pull Request #10008 - Add keyboard layout group for Serbian

I guess we'd better to have Bug 867883 fixed, to get rid of the strange keyboard grouping.
But no reason to block on that, so I am going to give this a r+.

I have some (minor) comments on pull request.
Good work, Mihai!

Comment 5

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Staś, can you suggest the right string for this question on GitHub: https://github.com/mozilla-b2g/gaia/pull/10008#discussion_r4427753?

Thanks!

Comment 6

[Staś Małolepszy :stas]

(In reply to Mihai Cirlanaru [:mihai][:mcirlanaru] from comment #5)
> Staś, can you suggest the right string for this question on GitHub:
> https://github.com/mozilla-b2g/gaia/pull/10008#discussion_r4427753?

Milos, as a a native Serbian speaker, can you help here, please?

Comment 7

[Milos Dinic [:Milos]]

(In reply to Staś Małolepszy :stas from comment #6)
> (In reply to Mihai Cirlanaru [:mihai][:mcirlanaru] from comment #5)
> > Staś, can you suggest the right string for this question on GitHub:
> > https://github.com/mozilla-b2g/gaia/pull/10008#discussion_r4427753?
> 
> Milos, as a a native Serbian speaker, can you help here, please?

Commented in https://github.com/mozilla-b2g/gaia/pull/10008#issuecomment-18906215

Comment 8

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Given that the menu label for the keyboard selection dialog is not a blocker for this patch, I updated the label for 'Serbian (Cyrillic)' to 'Српски (ћирилица)' and will file a follow-up bug regarding the fixed width of the dialog that breaks long labels like this one on two lines.

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/6c025bf6ccc48967069fe1c8dcfc191eb446c31b

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 6c025bf6ccc48967069fe1c8dcfc191eb446c31b to:
v1-train: 3c8b5b5207ff061757e3442b6094c503c9e101fd