872964 - wrong result for getTextBeforeOffset for start word boundary at text length offset

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

follow up of bug 855732. Discussed in bug 860013. Described at http://asurkov.blogspot.ru/2013/04/atx-text-pitfalls.html

Comment 1

[Trevor Saunders (:tbsaunde)]

Comment on attachment 750351 [details] [diff] [review]
patch

>+      } else {
>+        *aStartOffset = FindWordBoundary(offset, eDirPrevious, eStartWord);
>+        *aEndOffset = FindWordBoundary(*aStartOffset, eDirNext, eStartWord);
>+        if (*aEndOffset != offset) {
>+          *aEndOffset = *aStartOffset;
>+          *aStartOffset = FindWordBoundary(*aEndOffset, eDirPrevious, eStartWord);

it might be faster to use a local var for the start offset so the compiler doesn't need to worry about aliasing, but I really doubt it matters.

Comment 2

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3a447f55a848

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3a447f55a848