Closed
Bug 873033
Opened 12 years ago
Closed 12 years ago
[MMS] [UX] Messages thread view. Correct the line height for text inside msg bubbles
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:leo+, b2g18 fixed)
People
(Reporter: vicky, Assigned: jugglinmike)
References
Details
Attachments
(2 files)
comparison of the implementation vs prposed design
Line height should be 2.3 rem. Please see attachment that illustrates the difference between the phone's actual screenshot and the original design.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → mike
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #752901 -
Flags: review?(gnarf37)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 752901 [details] [diff] [review]
Fix line height
Review of attachment 752901 [details] [diff] [review]:
-----------------------------------------------------------------
r=me - borja wanted a CC on any css related reviews though
Attachment #752901 -
Flags: review?(gnarf37)
Attachment #752901 -
Flags: review?(fbsc)
Attachment #752901 -
Flags: review+
|
|
||
Updated•12 years ago
|
Attachment #752901 -
Flags: review?(felash)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 752901 [details] [diff] [review]
Fix line height
yeah, well, easy enough
I don't think borja would be angry if you land without his review here.
r=me :)
Attachment #752901 -
Flags: review?(felash)
Attachment #752901 -
Flags: review?(fbsc)
Attachment #752901 -
Flags: review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Landed at commit f63c63fbd2bfd1cd4e489be975b78ff1060bafdf
Thanks for reviewing, Julien and Corey
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
blocking-b2g: --- → leo+
|
||
Comment 5•11 years ago
|
||
Uplifted f63c63fbd2bfd1cd4e489be975b78ff1060bafdf to:
v1-train: 59ec7e38d819648f3a7364259923566453fae5f8
status-b2g18:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•