Closed
Bug 873087
Opened 12 years ago
Closed 12 years ago
lang file tags should be general purpose
Categories
(www.mozilla.org :: Bedrock, defect, P3)
www.mozilla.org
Bedrock
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: pmac, Assigned: dpoirier)
References
(Blocks 1 open bug)
Details
(Whiteboard: r=118547)
Attachments
(1 file)
2.44 KB,
patch
|
pmac
:
review+
|
Details | Diff | Splinter Review |
We've now got two lang file tags:
## active ##
## hide_form ##
These should really be available via a utility function that will give you the list of tags for a lang file and locale. It seems this method will grow in popularity as a way of changing things per-locale outside of a bedrock push.
Updated•12 years ago
|
Blocks: bedrock-l10n
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dpoirier
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #784488 -
Flags: review?(pmac)
Reporter | ||
Updated•12 years ago
|
Attachment #784488 -
Flags: review?(pmac) → review+
Reporter | ||
Comment 3•12 years ago
|
||
Looks great. Thanks!
Comment 5•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock
https://github.com/mozilla/bedrock/commit/d3836c1651fc4be1190a5254917f5e1c1afc161c
Bug 873087 - Generalized lang file tags
Support for lines like '## tag ##' in lang files, where tag can be any string.
For efficiency, tag lines must be the first lines in the file.
https://github.com/mozilla/bedrock/commit/2a1013eee1217e09c8b548b1fd9e99d9c78ad70b
Merge pull request #1126 from dpoirier/bug-873087-lang-file-tags
Bug 873087 - Generalized lang file tags
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•