Closed
Bug 873146
Opened 10 years ago
Closed 10 years ago
about: page favicons are not displayed in the "Your tabs from last time" section of about:home screen
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox23 verified, firefox24 verified)
VERIFIED
FIXED
Firefox 24
People
(Reporter: nalexander, Assigned: Margaret)
References
Details
Attachments
(5 files)
37.30 KB,
image/png
|
Details | |
52.57 KB,
image/png
|
Details | |
25.20 KB,
image/png
|
Details | |
52.93 KB,
image/png
|
Details | |
1.66 KB,
patch
|
bnicholson
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Screenshots will say it best.
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Comment 2•10 years ago
|
||
This is not specific to about:feedback.
Reporter | ||
Comment 3•10 years ago
|
||
Reporter | ||
Comment 4•10 years ago
|
||
margaret, wesj: I think y'all were working in this area recently.
Assignee | ||
Comment 6•10 years ago
|
||
So, there are two issues here. The main issue with about: pages is that we don't store about: URLs in history, so we're not finding a favicon for them when we call getFaviconForUrl in readLastTabs. The favicon *does* show up for about:firefox because it's a bookmark, so if you bookmark about:feedback, you will see the favicon show up ;) I'm not sure if it's worth fixing this issue, since it's rooted in how we handle history entries for about: pages. The second issue here is that when we don't find a favicon, we never end up calling updateImage, so we get that awkward white square. This is something that should definitely be fixed.
Assignee | ||
Comment 7•10 years ago
|
||
Here's a patch to fix the second issue I mentioned in my last comment.
Attachment #750682 -
Flags: review?(bnicholson)
Updated•10 years ago
|
Attachment #750682 -
Flags: review?(bnicholson) → review+
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/da75ba983321
Assignee | ||
Comment 9•10 years ago
|
||
This was a regression from bug 839855 (I tested in beta, and we show the default favicon for about:feedback in tabs from last time).
Blocks: 839855
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 750682 [details] [diff] [review] Use default favicon in "tabs from last time" if there's no stored favicon [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 839855 User impact if declined: about: pages have an ugly favicon in tabs from last time Testing completed (on m-c, etc.): tested locally Risk to taking this patch (and alternatives if risky): low-risk background change String or IDL/UUID changes made by this patch: n/a
Attachment #750682 -
Flags: approval-mozilla-aurora?
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/da75ba983321
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Updated•10 years ago
|
Attachment #750682 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 12•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/bf0fe0f70138
status-firefox23:
--- → fixed
status-firefox24:
--- → fixed
Comment 13•10 years ago
|
||
Verified fixed on: Build: Firefox for Android 24.0a1(2013-06-20) and Firefox for Android 23.0a2(2013-06-20) Device: Samsung Galaxy Nexus OS: Android 4.1.1
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•