873154 - Implement search results and filter bar

Status: RESOLVED WONTFIX

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Cassie McDaniel [:cassiemc]]

Attachment: Search and filter by bar design

The design process is captured in bug: 861388 and a description of the functionality from comment 3:

Clicking the search icon will pop down this bar where you can search for things or filter results. Page 2 shows the expanded filter bar (and what those filters should be, also listed in the PRD).

Results should filter into the grid gallery. Widths can be uniform though, so 4 columns. (This is the MVP solution FTW!)

FYI, this filter bar (sans search) will need to be present on several of the site's sections, so bear in mind it should be reusable.

Dale, assigning this to you for now but let Jen Fong know if you need help!

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Cassie: can you confirm that once a search query is run:

 - stamped items disappear
 - the grid goes to a 4x4 layout
 - there is a "More" button which adds another page of results should more than 16 results exist

None of that is shown in the mockup, but it's what I recall us discussing.

Comment 2

[Cassie McDaniel [:cassiemc]]

Yes, all this is confirmed. I spoke with Jen about this yesterday.

Brett and I just talked about adding another tab at the bottom, "Search", which would lock to the CTA bar alongside the "more" button. Clicking it would scroll the user up and pop down the search/filter bar. The use case we are considering is when a user is exploring content, they keep pressing that button to load more makes, this page gets ridiculously long, and the only way to filter or search from there is to scroll all the way back to the top and click the tiny mag glass. 

An alternative, add a "back to top" button once the page is a certain height that auto-scrolls the user back to the top of the page. 

Thoughts?

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

I like the first thing.

Comment 4

[Cassie McDaniel [:cassiemc]]

So we want to: add another tab at the bottom, "Search", which would lock to the CTA bar alongside the "more" button. Clicking it would scroll the user up and pop down the search/filter bar.

Comment 5

[Jen Fong-Adwent [:ednapiranha]]

As a note, Kate and I will be going back and forth on commits for this bug for the next day or two so ignore any initial commit as the final one.

Comment 6

[Jen Fong-Adwent [:ednapiranha]]

Attachment: https://github.com/mozilla/webmaker.org/pull/27

Comment 7

[Ross Bruniges [:boozeniges]]

Comment on attachment 753338 [details]
https://github.com/mozilla/webmaker.org/pull/27

A couple of nits that I think are worth fixing before merging this in...

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/887cacfad280bb366f593e15d4d05f2859d1336b
[bug 873154] initial commit of search filter layout

https://github.com/mozilla/webmaker.org/commit/99380c734fa2d265e88a78f9472a0baa18ca38d7
Merge pull request #27 from ednapiranha/bug873154

[bug 873154] initial commit of search filter layout

Comment 9

[Ross Bruniges [:boozeniges]]

Thanks for fixing those!

Comment 10

[inactivate account for kate]

Attachment: https://github.com/mozilla/webmaker.org/pull/28

Some button styles and UI stuff

Comment 11

[Jen Fong-Adwent [:ednapiranha]]

Comment on attachment 753389 [details] [review]
https://github.com/mozilla/webmaker.org/pull/28

r+wc

Comment 12

[Jen Fong-Adwent [:ednapiranha]]

Attachment: https://github.com/mozilla/webmaker.org/pull/30

Comment 13

[Ross Bruniges [:boozeniges]]

Comment on attachment 753806 [details]
https://github.com/mozilla/webmaker.org/pull/30

A couple of house-keeping related nits but the code looks good!

Comment 14

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/14cd31f93d2ca72abc9926330ad1a2338c4f34db
[bug 873154] search and filter functionality

https://github.com/mozilla/webmaker.org/commit/1272b0a0646c47c92ae1df03d00cc26145965306
Merge pull request #30 from ednapiranha/t873154

[bug 873154] Search and filter functionality

Comment 15

[Brett Gaylor [:brett]]

Taking a different approach in bug #876166