Closed Bug 873155 Opened 11 years ago Closed 11 years ago

Remove StackFrame argument duplication

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
When there are more actuals than formals, formals are duplicated on the stack so that JM could access them at a fixed offset. Now that JM is gone, we can remove this.

Patch also gets rid of the OVERFLOW_ARGS and UNDERFLOW_ARGS StackFrame flags.
Attachment #750560 - Flags: review?(luke)
Attached patch PatchSplinter Review
Update a comment.
Attachment #750560 - Attachment is obsolete: true
Attachment #750560 - Flags: review?(luke)
Attachment #750562 - Flags: review?(luke)
Comment on attachment 750562 [details] [diff] [review]
Patch

Review of attachment 750562 [details] [diff] [review]:
-----------------------------------------------------------------

Ahh, much nicer.

::: js/src/vm/ArgumentsObject.cpp
@@ +31,5 @@
>      JS_ASSERT_IF(frame.isStackFrame(), !frame.asStackFrame()->runningInIon());
>  
> +    JS_ASSERT(frame.numActualArgs() <= totalArgs);
> +    JS_ASSERT(frame.numFormalArgs() <= totalArgs);
> +    JS_ASSERT(Max(frame.numActualArgs(), frame.numFormalArgs()) == totalArgs);

Seems like the third assert subsumes the first two and they could be removed.
Attachment #750562 - Flags: review?(luke) → review+
Depends on: 868431
https://hg.mozilla.org/mozilla-central/rev/10106fdd2873
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: