Closed
Bug 873155
Opened 11 years ago
Closed 11 years ago
Remove StackFrame argument duplication
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file, 1 obsolete file)
32.93 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
When there are more actuals than formals, formals are duplicated on the stack so that JM could access them at a fixed offset. Now that JM is gone, we can remove this. Patch also gets rid of the OVERFLOW_ARGS and UNDERFLOW_ARGS StackFrame flags.
Attachment #750560 -
Flags: review?(luke)
Assignee | ||
Comment 1•11 years ago
|
||
Update a comment.
Attachment #750560 -
Attachment is obsolete: true
Attachment #750560 -
Flags: review?(luke)
Attachment #750562 -
Flags: review?(luke)
Comment 2•11 years ago
|
||
Comment on attachment 750562 [details] [diff] [review] Patch Review of attachment 750562 [details] [diff] [review]: ----------------------------------------------------------------- Ahh, much nicer. ::: js/src/vm/ArgumentsObject.cpp @@ +31,5 @@ > JS_ASSERT_IF(frame.isStackFrame(), !frame.asStackFrame()->runningInIon()); > > + JS_ASSERT(frame.numActualArgs() <= totalArgs); > + JS_ASSERT(frame.numFormalArgs() <= totalArgs); > + JS_ASSERT(Max(frame.numActualArgs(), frame.numFormalArgs()) == totalArgs); Seems like the third assert subsumes the first two and they could be removed.
Attachment #750562 -
Flags: review?(luke) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Pushed with nit addressed: https://hg.mozilla.org/integration/mozilla-inbound/rev/b52106ac0817
Comment 4•11 years ago
|
||
Backed out for jit-test bustage at Jan's request. https://hg.mozilla.org/integration/mozilla-inbound/rev/0e3678635f5b
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/10106fdd2873 (Try: https://tbpl.mozilla.org/?tree=Try&rev=4bab52e636eb)
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/10106fdd2873
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•