873156 - Rename profile-before-change2 to something better

Status: RESOLVED INVALID

(Core :: XPCOM, defect, P5)

Description

[(no longer active)]

Like, profile-before-change-last-chance, or really, anything which doesn't have a number in it!

Nathan, wanna take this on please?

Comment 1

[Benjamin Smedberg]

I suggested the current name; not that I really care, but I'm not sure why this name is so terrible.

Comment 2

[(no longer active)]

(In reply to comment #1)
> I suggested the current name; not that I really care, but I'm not sure why this
> name is so terrible.

Because it doesn't communicate anything about what the notification is supposed to do.

Comment 3

[Marco Bonardo [:mak]]

did we really introduce such thing? I know it's likely not the right place to open such discussion, though if we start introducing multipe layers to notifications it's likely better to keep the current naming, and likely someone will add profile-before-change3 (not that I think it's a good idea, but having to remember many different names is not any better).
FWIW, why not using profile-change-teardown and profile-before-change when in need of synchronized work, or firing a custom notification at profile-before-change for syncing with specific consumers (like on p-b-c serviceA fires serviceA-shutdown and other services depending on that listen to servicesA-shutdown) instead of layering p-b-c?

Comment 4

[Marco Bonardo [:mak]]

Looks like profile-before-change2 has been renamed and split into profile-before-change-qm, profile-before-change-telemetry
so this is no more valid.