Closed
Bug 8734
Opened 25 years ago
Closed 24 years ago
xpidl produces output file in same dir as input file
Categories
(Core :: XPCOM, defect, P3)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
Future
People
(Reporter: mike+mozilla, Assigned: mike+mozilla)
Details
Attachments
(2 files)
2.21 KB,
patch
|
Details | Diff | Splinter Review | |
2.95 KB,
patch
|
Details | Diff | Splinter Review |
... even when the input file is many directories away. (I'm guessing -o ../foo/whatever still works. xpidl -m java -I ../../../dist/idl ../../../dist/idl/nsISupports.idl produces nsISupports.java way up in ../../../dist/idl. I'd expect it to work like other tools, and put it in the current directory.
Updated•25 years ago
|
Status: NEW → ASSIGNED
Comment 1•25 years ago
|
||
I have a trivial patch to fix this on Unix. Will do Windows, where we accept forward and backward slash and thus accept funky paths like ../foo\bar.idl I don't think there's an idea of "working directory" on Mac, so I'll leave that well enough alone.
Updated•25 years ago
|
Assignee: mccabe → mang
Status: ASSIGNED → NEW
Updated•25 years ago
|
Status: NEW → ASSIGNED
Updated•25 years ago
|
Assignee: mang → mccabe
Status: ASSIGNED → NEW
Comment 2•25 years ago
|
||
Mass reassign to mccabe since I'm outta here.
Assignee | ||
Comment 3•25 years ago
|
||
Mass accept as ASSIGNED of xpidl bugs
Assignee | ||
Comment 4•24 years ago
|
||
[SPAM] Marking milestone 'future' as part of nsbeta3 triage.
Target Milestone: --- → Future
Assignee | ||
Comment 5•24 years ago
|
||
Attaching proposed fix; use / as pathsep for XP_UNIX, \ for XP_WIN. Mang, care to review?
Assignee | ||
Comment 6•24 years ago
|
||
Comment 7•24 years ago
|
||
I think you got the path separators confused. Should be '/' on Unix and '\\' on Windows. Also, Merriam-Webster says it's "separator".
Comment 8•24 years ago
|
||
Comment 9•24 years ago
|
||
Just-attached patch is same as mccabe's previous one with path separators exchanged, spelling corrected, and a one-character doc fix to xpidl.c Also added myself to contributors line, for previous work. I hesitate to give an r= for something that I've touched, since of course it looks good to me. Maybe get jband to take a look and do super review?
Comment 10•24 years ago
|
||
Someone should also make sure this doesn't break anything in the client build due to dependency on old behaviour. I don't have time to do that right this moment.
Comment 11•24 years ago
|
||
sr=jband. Looks good to me. However, I did not try a full build to verify that it doesn't cause any problems.
Assignee | ||
Comment 12•24 years ago
|
||
Thanks for the reviews. I've done a full build and it works fine; this change only affects behavior when no -o outputfile name is supplied, and our build system always does. It may save some confusion for people first starting with xpidl.
Assignee | ||
Comment 13•24 years ago
|
||
Fix checked in. (How was your weekend, Mike?)
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•