xpidl produces output file in same dir as input file

RESOLVED FIXED in Future

Status

()

P3
minor
RESOLVED FIXED
19 years ago
10 years ago

People

(Reporter: mike+mozilla, Assigned: mike+mozilla)

Tracking

Trunk
Future
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

19 years ago
... even when the input file is many directories away.  (I'm guessing -o
../foo/whatever still works.

xpidl -m java -I ../../../dist/idl ../../../dist/idl/nsISupports.idl

produces nsISupports.java way up in ../../../dist/idl.  I'd expect it to work
like other tools, and put it in the current directory.

Updated

19 years ago
Status: NEW → ASSIGNED

Comment 1

19 years ago
I have a trivial patch to fix this on Unix.  Will do Windows, where we accept
forward and backward slash and thus accept funky paths like ../foo\bar.idl

I don't think there's an idea of "working directory" on Mac, so I'll leave that
well enough alone.

Updated

19 years ago
Assignee: mccabe → mang
Status: ASSIGNED → NEW

Updated

19 years ago
Status: NEW → ASSIGNED

Updated

19 years ago
Assignee: mang → mccabe
Status: ASSIGNED → NEW

Comment 2

19 years ago
Mass reassign to mccabe since I'm outta here.
(Assignee)

Comment 3

19 years ago
Mass accept as ASSIGNED of xpidl bugs
(Assignee)

Comment 4

18 years ago
[SPAM] Marking milestone 'future' as part of nsbeta3 triage.
Target Milestone: --- → Future
(Assignee)

Comment 5

18 years ago
Attaching proposed fix; use / as pathsep for XP_UNIX, \ for XP_WIN.

Mang, care to review?
(Assignee)

Comment 6

18 years ago
Created attachment 19963 [details] [diff] [review]
If no -o flag, use filename part after last sep. as output.

Comment 7

18 years ago
I think you got the path separators confused.  Should be '/' on Unix and '\\' on
Windows.  Also, Merriam-Webster says it's "separator".

Comment 8

18 years ago
Created attachment 20065 [details] [diff] [review]
proposed patch

Comment 9

18 years ago
Just-attached patch is same as mccabe's previous one with path separators
exchanged, spelling corrected, and a one-character doc fix to xpidl.c

Also added myself to contributors line, for previous work.

I hesitate to give an r= for something that I've touched, since of course it
looks good to me.  Maybe get jband to take a look and do super review?

Comment 10

18 years ago
Someone should also make sure this doesn't break anything in the client build
due to dependency on old behaviour.  I don't have time to do that right this
moment.

Comment 11

18 years ago
sr=jband. Looks good to me. However, I did not try a full build to verify that
it doesn't cause any problems.
(Assignee)

Comment 12

18 years ago
Thanks for the reviews.  I've done a full build and it works fine; this change
only affects behavior when no -o outputfile name is supplied, and our build
system always does.  It may save some confusion for people first starting with
xpidl.
(Assignee)

Comment 13

18 years ago
Fix checked in.  (How was your weekend, Mike?)
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Updated

10 years ago
Component: xpidl → XPCOM
QA Contact: mike+mozilla → xpcom
You need to log in before you can comment on or make changes to this bug.