Closed Bug 873429 Opened 8 years ago Closed 8 years ago
Form assistant suggestions is not dismissed while entering different letters
Build: Aurora 23.0a2 05/16 Device: Asus Eee Transformers OS: Android 4.0.3 Steps to Reproduce: 1. Go to gmail.com 2. Enter a user name - tap enter - repeat with a different user name 3. Enter a 3rd user name - starting with different letter from the above 2 Expected Results: - no suggestion present Actual Results: - the first 2 names as present as suggestions Please see video - http://www.youtube.com/watch?v=pq2Wnc4mXVM . Suggestions can be dismissed if you will tap outside the form.
The regression window for this issue is: 1. mozilla central good build: 11.05.2013 bad build: 12.05.2013 pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=179e29a23c56&tochange=d68224f5325b 2. inbound good build: 1368163665 bad build: 1368166544 pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6035591d40f8&tochange=96fe69d53f35
Looks like async form history broke this.
Assignee: nobody → margaret.leibovic
Yo dawg, there are a lot of callbacks in this code. Turns out there were two slight logic errors that caused us to never call _hideFormAssistPopup when we should.
Attachment #751868 - Flags: review?(mark.finkle)
Comment on attachment 751868 [details] [diff] [review] patch Off topic: I just realized I have a strong dislike for "fat arrow" function syntax. It's the work of the devil.
Attachment #751868 - Flags: review?(mark.finkle) → review+
Comment on attachment 751868 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 566746 User impact if declined: form autocomplete popup doesn't hide when it should Testing completed (on m-c, etc.): tested locally (just landed on inbound) Risk to taking this patch (and alternatives if risky): low-risk, isolated small logic fixes String or IDL/UUID changes made by this patch: n/a
Attachment #751868 - Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Attachment #751868 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.