Closed
Bug 873494
Opened 13 years ago
Closed 13 years ago
tutorials code has a dependency on makapi that allows the entire page to break
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Unassigned)
Details
this means that if the makeapi is down, thimble is down, too, despite not needing to be (because the makeapi does not impact thimble itself, not even publication).
Updated•13 years ago
|
Assignee: nobody → scott
As a secondary, we need to check what happens when someone remixes a project that was never initially-makeapi-published:
- makeapi not available
- user published in thimble
- works, but no make publish happens
- makeapi comes back up
- user remixes, published the update
- works, resaved/republished
- what happens with makeapi call now? does it try to update a nonexistent make? does it work anyway? open question, needs an answer.
Assignee: scott → nobody
Comment 2•13 years ago
|
||
If you update a publish that was not in the makeapi previous, it should now create a publish in the makeapi. It does its own check for if it is already there, if not, add it, if so, update it.
nice, that removes one concern. Can we make Thimble not "die" if makeapi isn't available, by pulling its js include out from the require chain?
Summary: thimble seems to be hard-dependent on the makeapi exist at page-load. → thimble seems to be hard-dependent on the makeapi existing at page-load.
looking at the code, the tutorials .js (just before loadTutorials() function) has a dependency on the makeapi, but this can break the entire pageload process if the makeapi is not available, even though the only thing it'll do is not let use see tutorials. This should be refactored so it doesn't have the power to break all of Thimble.
Assignee: nobody → scott
Summary: thimble seems to be hard-dependent on the makeapi existing at page-load. → tutorials code has a dependency on makapi that allows the entire page to break
unassigning pending reprioritisation
Assignee: pomax → nobody
Status: ASSIGNED → NEW
Comment 6•13 years ago
|
||
The frontend loads even if the MakeAPI isn't available
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•