Closed
Bug 873605
Opened 13 years ago
Closed 13 years ago
Update thimble to use changes in the makeapi
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: thecount, Assigned: thecount)
Details
Attachments
(1 file)
A bunch of changes happened in the makeapi.
It is at version 0.1.5 now.
A few api changes too.
Updates coming.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → scott
|
|
Assignee | |
Comment 1•13 years ago
|
||
Changes:
Make api constructor changed, updates to be make.makeAPI() when it used to just be make(). There is now make.fakeAPI/makeAPI()
hits is now gone from the results.
A tag now flags as an application tag if it sees a :. Going to have to escape this for now, filing another bug to make the tutorial an app tag.
Attachment #751155 -
Flags: review?(pomax)
Attachment #751155 -
Flags: review?(chris)
Comment on attachment 751155 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/68
some questions in the pull request
Attachment #751155 -
Flags: review?(pomax) → review-
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 751155 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/68
Added comments to help exlain what's going on.
Attachment #751155 -
Flags: review- → review?(pomax)
|
|
Assignee | |
Comment 4•13 years ago
|
||
explain*
|
|
Assignee | |
Comment 5•13 years ago
|
||
Filed bug 873610 for the app tags.
|
||
Comment 6•13 years ago
|
||
Comment on attachment 751155 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/68
looks good from my end
Attachment #751155 -
Flags: review?(chris) → review+
Comment on attachment 751155 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/68
this works for me. R+ with a rebase
Attachment #751155 -
Flags: review?(pomax) → review+
|
|
Assignee | |
Comment 8•13 years ago
|
||
Staged: https://github.com/mozilla/thimble.webmaker.org/commit/7eafd9885218f48d84a94d0f26ccf90e4c10b22b
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•