873623 - Assertion failure: _mOwningThread.GetThread() == PR_GetCurrentThread() (nsDOMMemoryFileDataOwnerMemoryReporter not thread-safe)

Status: RESOLVED DUPLICATE of bug 832609

(Core Graveyard :: File Handling, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

While working on bug 872421, I intermittently encounter the following error during shutdown:

Assertion failure: _mOwningThread.GetThread() == PR_GetCurrentThread() (nsDOMMemoryFileDataOwnerMemoryReporter not thread-safe), at /Users/david/Documents/Code/mc-osfile/content/base/src/nsDOMFile.cpp:705

I will try and produce a simple test case.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Non-minimal test

Attaching a sample that intermittently causes the assertion failure.
I haven't minimized it yet.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Stack trace

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Justin, do you have any idea of what happens?

Comment 4

[Justin Lebar (not reading bugmail)]

(In reply to David Rajchenbach Teller [:Yoric] from comment #3)
> Justin, do you have any idea of what happens?

I bet we're calling nsDOMMemoryFile::DataOwner::EnsureMemoryReporterRegistered off the main thread.  Probably because of a worker.

This means that we're manipulating a linked list off the main thread in the DataOwner constructor, which is also bad.

I could have sworn we saw and fixed this bug, but I can't find it now.

Comment 5

[Justin Lebar (not reading bugmail)]

Thanks a lot for filing this; bug 832609 fell off the radar.