873750 - fix communications/contacts tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Julien Wajsberg [:julienw]]

Various mocks are incorrectly used.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: WIP patch v1

* use the correct name for the facebook mock
* various fixes
---
 .../communications/contacts/test/unit/link_test.js |   22 +++++++++++---------
 apps/communications/contacts/test/unit/mock_fb.js  |   12 +++++------
 apps/communications/test/unit/setup.js             |    1 +
 3 files changed, 19 insertions(+), 16 deletions(-)

It seems we miss a file defining MockAllFacebookContacts.

Comment 2

[Julien Wajsberg [:julienw]]

Jose, I think we miss the mock file defining MockAllFacebookContacts. Could you either attach it to this bug or take my patch and finish it ?

Comment 3

[Julien Wajsberg [:julienw]]

(see also PR https://github.com/mozilla-b2g/gaia/pull/9861)

Comment 4

[Jose Manuel Cantera]

Attachment: Fix the link tests by pointing to the proper Mockfb object

asking for Cristian's review as I believe Julien is on bank holiday today.

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 751614 [details]
Fix the link tests by pointing to the proper Mockfb object

:) perfect!

Comment 6

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/9dc8606977471cc3d525d579c80da631f92de549

Comment 7

[Jose Manuel Cantera]

Attachment: Missing FB Link test files

Comment 8

[Julien Wajsberg [:julienw]]

I don't exactly understand why you haven't used my WIP patch ?

It was fixing various problems (eg: Mockfb.utils is defined twice), it was using the new "load_body_html_helper" that makes it easier to create tests, and the only thing that was missing was the file mock_linked_contacts.js that you finally supplied in your latest patch, as I asked in my comment 2.

I think it would have saved you lots of time (and my time doing the WIP patch would not have been wasted).

Anyway I'm happy that the tests are fixed, thanks to you.