Last Comment Bug 873754 - Tweak Last-Modified date for new feed subscribe
: Tweak Last-Modified date for new feed subscribe
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Feed Reader (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Thunderbird 24.0
Assigned To: alta88
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-18 05:32 PDT by alta88
Modified: 2013-05-20 05:01 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.29 KB, patch)
2013-05-18 05:34 PDT, alta88
mkmelin+mozilla: review+
Details | Diff | Splinter Review
patch for checkin (2.63 KB, patch)
2013-05-18 12:40 PDT, alta88
alta88: review+
Details | Diff | Splinter Review

Description alta88 2013-05-18 05:32:42 PDT
Some servers will 304 a date as old as 1970, likely 2 byte Y2K hacks vs real fixes, a more recent date is needed.  Both feeds encountered work with 2000.
Comment 1 alta88 2013-05-18 05:34:55 PDT
Created attachment 751349 [details] [diff] [review]
patch


magnus, i didn't realize you were now /mailnews as well..
Comment 2 Magnus Melin 2013-05-18 11:44:50 PDT
I'm not, actually. Though with /newsblog i guess it should be ok given its history in /mail.
Comment 3 Magnus Melin 2013-05-18 11:50:22 PDT
Comment on attachment 751349 [details] [diff] [review]
patch

Review of attachment 751349 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable to me.

::: mailnews/extensions/newsblog/content/utils.js
@@ +73,5 @@
>    INVALID_ITEM_PURGE_DELAY: 24 * 60 * 60 * 1000,
>  
> +  // Some servers will 304 a Last-Modified date from as far back as the actual
> +  // Epoch, so use the beginning of the century.
> +  EPOCHDATE: "Sat, 01 Jan 2000 00:00:00 GMT",

I don't think this should be named EPOCHDATE then - and since it's just used once i'd just remove this constant and use the value inline.
Comment 4 alta88 2013-05-18 12:40:45 PDT
Created attachment 751381 [details] [diff] [review]
patch for checkin

updated for comments.
Comment 5 Ryan VanderMeulen [:RyanVM] 2013-05-20 05:01:38 PDT
https://hg.mozilla.org/comm-central/rev/0b43c4940181

Note You need to log in before you can comment on or make changes to this bug.