Closed Bug 873754 Opened 7 years ago Closed 7 years ago

Tweak Last-Modified date for new feed subscribe

Categories

(MailNews Core :: Feed Reader, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 24.0

People

(Reporter: alta88, Assigned: alta88)

Details

Attachments

(1 file, 1 obsolete file)

Some servers will 304 a date as old as 1970, likely 2 byte Y2K hacks vs real fixes, a more recent date is needed.  Both feeds encountered work with 2000.
Attached patch patch (obsolete) — Splinter Review
magnus, i didn't realize you were now /mailnews as well..
Assignee: nobody → alta88
Attachment #751349 - Flags: review?(mkmelin+mozilla)
I'm not, actually. Though with /newsblog i guess it should be ok given its history in /mail.
Comment on attachment 751349 [details] [diff] [review]
patch

Review of attachment 751349 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable to me.

::: mailnews/extensions/newsblog/content/utils.js
@@ +73,5 @@
>    INVALID_ITEM_PURGE_DELAY: 24 * 60 * 60 * 1000,
>  
> +  // Some servers will 304 a Last-Modified date from as far back as the actual
> +  // Epoch, so use the beginning of the century.
> +  EPOCHDATE: "Sat, 01 Jan 2000 00:00:00 GMT",

I don't think this should be named EPOCHDATE then - and since it's just used once i'd just remove this constant and use the value inline.
Attachment #751349 - Flags: review?(mkmelin+mozilla) → review+
updated for comments.
Attachment #751349 - Attachment is obsolete: true
Attachment #751381 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/0b43c4940181
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.