If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Enhanced Customization API

UNCONFIRMED
Unassigned

Status

()

Core
General
UNCONFIRMED
4 years ago
3 years ago

People

(Reporter: riadh.chtara, Unassigned)

Tracking

24 Branch
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 18 obsolete attachments)

176.86 KB, patch
Details | Diff | Splinter Review
(Reporter)

Description

4 years ago
Created attachment 751442 [details] [diff] [review]
internalapi.diff

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like Gecko) Ubuntu Chromium/25.0.1364.160 Chrome/25.0.1364.160 Safari/537.22

Steps to reproduce:

GSOC Enhanced Customization APIs: Internal APIs prototype
(Reporter)

Comment 1

4 years ago
Hey guys,
This the prototype of the internal apis I was talking about.
The prototype supports the following things
* synchronous set of a protected pref
* synchronous get of a protected pref
* asynchronous set of a protected pref
* asynchronous get of a protected pref
* synchronous set of many protected prefs
* synchronous get of many protected prefs
* asynchronous set of many protected prefs
* asynchronous get of many protected prefs
There is a UI asking the user for confirmation that is shown when setting same prefs. But this part is not finished yet. 
I will focus on solving same bugs as Kris suggested to me to improve my chances to get selected for gsoc.
If i will be chosen (which will be by the way awesome), I will continue working to improve the internal apis based on the prototype.
(Reporter)

Comment 2

4 years ago
This an example of addon that uses the internal apis:

const { Cu } = require("chrome");
Cu.import("resource://gre/modules/EnhancedCustomizationAPIs.jsm");
DBhandler.init();
DBhandler.dbconnect();


DBhandler.dbset("browser.newtab.url", "www.gmail.com" , "{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}", console.log);


(By the way the following lines will be included to a js file that's loaded at firefox start (browser.js) so the developer will not need to include them)  
DBhandler.init();
DBhandler.dbconnect();


DBhandler will be also renamed to CustomizeAPIs or something similar to that
Component: Untriaged → General
Product: Firefox → Core
(Reporter)

Comment 3

4 years ago
Created attachment 756541 [details] [diff] [review]
adding ui+message
Attachment #751442 - Attachment is obsolete: true
Attachment #756541 - Flags: review?
(Reporter)

Comment 4

4 years ago
Created attachment 756544 [details] [diff] [review]
adding ui+message
Attachment #756541 - Attachment is obsolete: true
Attachment #756541 - Flags: review?
Attachment #756544 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 5

4 years ago
Created attachment 756547 [details]
screenshot
Attachment #756547 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 6

4 years ago
Created attachment 757168 [details] [diff] [review]
adding exceptions / creating Customize object
Attachment #756544 - Attachment is obsolete: true
Attachment #756544 - Flags: review?(kmaglione+bmo)
(Reporter)

Updated

4 years ago
Attachment #757168 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 7

4 years ago
Created attachment 758726 [details] [diff] [review]
adding some tests/ fixing some bugs
Attachment #757168 - Attachment is obsolete: true
Attachment #757168 - Flags: review?(kmaglione+bmo)
Attachment #758726 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 8

4 years ago
Internal apis almost finished
(Reporter)

Comment 9

4 years ago
Created attachment 760109 [details] [diff] [review]
fixing bugs
Attachment #758726 - Attachment is obsolete: true
Attachment #758726 - Flags: review?(kmaglione+bmo)
Attachment #760109 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 10

4 years ago
Created attachment 763729 [details] [diff] [review]
internal  apis
Attachment #756547 - Attachment is obsolete: true
Attachment #756547 - Flags: review?(kmaglione+bmo)
Attachment #763729 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 11

4 years ago
Internal apis with tests
(Reporter)

Comment 12

4 years ago
Created attachment 764302 [details] [diff] [review]
Enhanced Customization APIs- getmany setmany bug fixed
Attachment #760109 - Attachment is obsolete: true
Attachment #763729 - Attachment is obsolete: true
Attachment #760109 - Flags: review?(kmaglione+bmo)
Attachment #763729 - Flags: review?(kmaglione+bmo)
(Reporter)

Updated

4 years ago
Attachment #764302 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 13

4 years ago
Created attachment 765367 [details] [diff] [review]
Enhanced Customization APIs- dead observers  bug fixed
Attachment #765367 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 14

4 years ago
Created attachment 769339 [details] [diff] [review]
latest patch: beginning of the replacement of the old apis with the new ones
Attachment #764302 - Attachment is obsolete: true
Attachment #765367 - Attachment is obsolete: true
Attachment #764302 - Flags: review?(kmaglione+bmo)
Attachment #765367 - Flags: review?(kmaglione+bmo)
(Reporter)

Updated

4 years ago
Attachment #769339 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 15

4 years ago
Created attachment 772857 [details] [diff] [review]
replacement of the old apis with the new ones
Attachment #769339 - Attachment is obsolete: true
Attachment #769339 - Flags: review?(kmaglione+bmo)
Attachment #772857 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 16

4 years ago
Created attachment 791821 [details] [diff] [review]
new version : incldues the beta of external + addons sdk apis
Attachment #772857 - Attachment is obsolete: true
Attachment #772857 - Flags: review?(kmaglione+bmo)
Attachment #791821 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 17

4 years ago
Created attachment 798305 [details] [diff] [review]
deleteoldentries.diff

Fixing bugs, tests are now working
Attachment #791821 - Attachment is obsolete: true
Attachment #791821 - Flags: review?(kmaglione+bmo)
Attachment #798305 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 18

4 years ago
Created attachment 802870 [details] [diff] [review]
newcmdmsg.diff
Attachment #798305 - Attachment is obsolete: true
Attachment #798305 - Flags: review?(kmaglione+bmo)
Attachment #802870 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 19

4 years ago
Created attachment 807702 [details] [diff] [review]
adding save to path option to external api
Attachment #802870 - Attachment is obsolete: true
Attachment #802870 - Flags: review?(kmaglione+bmo)
Attachment #807702 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 20

4 years ago
Created attachment 809675 [details] [diff] [review]
Adding save results to file option

Adding saving result to file option to external api
Attachment #807702 - Attachment is obsolete: true
Attachment #807702 - Flags: review?(kmaglione+bmo)
Attachment #809675 - Flags: review?(kmaglione+bmo)
(Reporter)

Updated

4 years ago
Attachment #809675 - Attachment description: src_135816_to_135782.diff → Adding save results to file option
(Reporter)

Updated

4 years ago
Summary: Enhanced Customization APIs: Internal APIs → Enhanced Customization APIs
(Reporter)

Updated

4 years ago
Summary: Enhanced Customization APIs → Enhanced Customization API
(Reporter)

Comment 21

4 years ago
Created attachment 810560 [details] [diff] [review]
refactoring
Attachment #809675 - Attachment is obsolete: true
Attachment #809675 - Flags: review?(kmaglione+bmo)
Attachment #810560 - Flags: review?(kmaglione+bmo)
(Reporter)

Comment 22

4 years ago
Created attachment 813099 [details] [diff] [review]
Merging+ refactoring

Merging the updates + refactoring
Attachment #810560 - Attachment is obsolete: true
Attachment #810560 - Flags: review?(kmaglione+bmo)
(Reporter)

Updated

4 years ago
Attachment #813099 - Attachment description: src_148827_to_148833.diff → Merging+ refactoring
Attachment #813099 - Flags: review?(kmaglione+bmo)
Attachment #813099 - Flags: review?(kmaglione+bmo)
You need to log in before you can comment on or make changes to this bug.