Build broken VS2012; "msvc_raise_wrappers.h(15) : fatal error C1004: unexpected end-of-file found"

RESOLVED FIXED in mozilla24

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: cpearce, Assigned: vlad)

Tracking

Trunk
mozilla24
x86_64
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

As reported by Yuan Pengfei in bug 864035 comment 16, the build is currently broken in VS2012.

This makes the productivity fairy sad.

BackgroundFileSaver.cpp
c:\Users\Bob\src\m-c\config\rules.mk:1075:0$ c:/Users/Bob/src/m-c/objdir/_virtualenv/Scripts/python.exe -O c:/Users/Bob/src/m-c/build/cl.py cl -FoBackgroundFile
Saver.obj -c -D_HAS_EXCEPTIONS=0 -I../../../dist/stl_wrappers  -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_N
S_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DNO_NSPR_10_SUPPORT -DEXCLUDE_SKIA_DEPENDENCIES  -DUNICODE -D_UNICODE -DNOMINMAX -D_CRT_RAND_S -DCERT_CHAIN
_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN  -DCOMPILER_MSVC -D
IMPL_NS_NET -Ic:/Users/Bob/src/m-c/dom/base -Ic:/Users/Bob/src/m-c/ipc/chromium/src -Ic:/Users/Bob/src/m-c/ipc/glue -I../../../ipc/ipdl/_ipdlheaders  -Ic:/Users
/Bob/src/m-c/netwerk/base/src -I. -I../../../dist/include  -Ic:/Users/Bob/src/m-c/objdir/dist/include/nspr -Ic:/Users/Bob/src/m-c/objdir/dist/include/nss
 -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DDEBUG -D_DEBUG -DTRACING -Zi -Oy-  -MDd
        -FI ../../../dist/include/mozilla-config.h -DMOZILLA_CLIENT  c:/Users/Bob/src/m-c/netwerk/base/src/BackgroundFileSaver.cpp
BackgroundFileSaver.cpp
c:\users\bob\src\m-c\objdir\dist\include\mozilla\msvc_raise_wrappers.h(15) : fatal error C1004: unexpected end-of-file found
c:\Users\Bob\src\m-c\config\rules.mk:1075:0: command 'c:/Users/Bob/src/m-c/objdir/_virtualenv/Scripts/python.exe -O c:/Users/Bob/src/m-c/build/cl.py cl -FoBackg
roundFileSaver.obj -c -D_HAS_EXCEPTIONS=0 -I../../../dist/stl_wrappers  -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX
-D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DNO_NSPR_10_SUPPORT -DEXCLUDE_SKIA_DEPENDENCIES  -DUNICODE -D_UNICODE -DNOMINMAX -D_CRT_RAND_S -DC
ERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN  -DCOMPILE
R_MSVC -DIMPL_NS_NET -Ic:/Users/Bob/src/m-c/dom/base -Ic:/Users/Bob/src/m-c/ipc/chromium/src -Ic:/Users/Bob/src/m-c/ipc/glue -I../../../ipc/ipdl/_ipdlheaders  -
Ic:/Users/Bob/src/m-c/netwerk/base/src -I. -I../../../dist/include  -Ic:/Users/Bob/src/m-c/objdir/dist/include/nspr -Ic:/Users/Bob/src/m-c/objdir/dist/include/n
ss        -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DDEBUG -D_DEBUG -DTRACING -Zi -Oy-
  -MDd           -FI ../../../dist/include/mozilla-config.h -DMOZILLA_CLIENT  c:/Users/Bob/src/m-c/netwerk/base/src/BackgroundFileSaver.cpp' failed, return code
 2
c:\Users\Bob\src\m-c\config\rules.mk:644:0: command 'c:/mozilla-build/python/python.exe c:/Users/Bob/src/m-c/build/pymake/pymake/../make.py libs' failed, return
 code 2
So that breakage is because of the #error -- MSVC has a bug where #error needs to have DOS line endings in order to be displayed, otherwise you get the issue here.

So the actual build issue is that we're hitting this #error:

#ifdef _XUTILITY_
#  error "Unabled to wrap _X[exception](); CRT versions already declared"
#endif
Will |MOZ_STATIC_ASSERT(false, "Unabled to wrap ...")| work?
Probably; it's not actually a big deal, as long as people know that they're hitting the #error and not some weird compiler bug.  The bigger issue is that we're actually hitting the #error...
Fixed in https://hg.mozilla.org/integration/mozilla-inbound/rev/20949db75c00
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Not fixed until it hits m-c.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/20949db75c00
Assignee: nobody → vladimir
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.