Closed Bug 874008 Opened 8 years ago Closed 8 years ago

Check format strings for r_log

Categories

(Core :: WebRTC: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: abr, Assigned: abr)

Details

(Whiteboard: [WebRTC][blocking-webrtc-][qa-])

Attachments

(2 files, 1 obsolete file)

We should add format-string checking for the r_log system used in
our ICE library
Attached patch Check format strings for r_log (obsolete) — Splinter Review
Adds GCC format-string checks to r_log and its relatives.
Attachment #751630 - Flags: review?(ekr)
Attachment #751630 - Attachment is obsolete: true
Attachment #751630 - Flags: review?(ekr)
Attachment #751664 - Flags: review?(ekr)
Attachment #751664 - Flags: review?(ekr) → review+
Whiteboard: [WebRTC][blocking-webrtc-]
Attached patch Fix bustageSplinter Review
Attachment #751950 - Flags: review?(ekr)
Comment on attachment 751950 [details] [diff] [review]
Fix bustage

Review of attachment 751950 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #751950 - Flags: review?(ekr) → review+
https://hg.mozilla.org/mozilla-central/rev/7571fcebd2a0
https://hg.mozilla.org/mozilla-central/rev/399dc3feb020
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Whiteboard: [WebRTC][blocking-webrtc-] → [WebRTC][blocking-webrtc-][qa-]
You need to log in before you can comment on or make changes to this bug.