Closed Bug 874008 Opened 12 years ago Closed 12 years ago

Check format strings for r_log

Categories

(Core :: WebRTC: Networking, defect)

Product:
Core
Component:
WebRTC: Networking
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla24

People

(Reporter: abr, Assigned: abr)

Details

(Whiteboard: [WebRTC][blocking-webrtc-][qa-])

Attachments

(2 files, 1 obsolete file)

Check format strings for r_log
4.61 KB, patch
ekr
: review+
Details | Diff | Splinter Review
Fix bustage
1.04 KB, patch
ekr
: review+
Details | Diff | Splinter Review 
We should add format-string checking for the r_log system used in
our ICE library
Attached patch Check format strings for r_log (obsolete) — — Splinter Review 
Adds GCC format-string checks to r_log and its relatives.
Attachment #751630 - Flags: review?(ekr)

  

  



    
  

        Attachment #751630 -
        Attachment is obsolete: true

        Attachment #751630 -
        Flags: review?(ekr)

    
  

        Attachment #751664 -
        Flags: review?(ekr)

    
  

        Attachment #751664 -
        Flags: review?(ekr) → review+
Whiteboard: [WebRTC][blocking-webrtc-]

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/7571fcebd2a0

  

  



    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix bustage
        — 
          — Splinter Review
      

    


  

  

  



    
  

        Attachment #751950 -
        Flags: review?(ekr)

    
    

    
  
Comment on attachment 751950 [details] [diff] [review]
Fix bustage

Review of attachment 751950 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

  

  



        Attachment #751950 -
        Flags: review?(ekr) → review+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/399dc3feb020

  

  



    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/7571fcebd2a0
https://hg.mozilla.org/mozilla-central/rev/399dc3feb020

  

  


Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Whiteboard: [WebRTC][blocking-webrtc-] → [WebRTC][blocking-webrtc-][qa-]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: