874046 - Three-state UI for DNT strings should not end with a period

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The strings at http://hg.mozilla.org/mozilla-central/annotate/ca7f8131a8d4/browser/locales/en-US/chrome/browser/preferences/privacy.dtd#l7 all end with a period, but I don't see any other strings related to a checkbox or radio button within the Preferences that ends with a period.

For internal consistency we should remove these periods.

Comment 1

[rsx11m]

Attachment: Proposed patch

Straight-forward to fix. Since some localizations have added the periods already but others didn't, I'm changing the entity names to alert them that they may need to make a modification in those strings.

I don't know what the "in-content" branch is about, but made corresponding changes there as well.

Comment 2

[rsx11m]

Thanks for the quick review, push for mozilla-inbound please.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7183748586f1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7183748586f1

Comment 5

[rsx11m]

(In reply to rsx11m from comment #1)
> I don't know what the "in-content" branch is about, but made corresponding
> changes there as well.

I see, figured it out - setting browser.preferences.inContent shows that part.