Make CallSetup hold a Rooted to the passed-in object

RESOLVED FIXED in mozilla24

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

unspecified
mozilla24
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Right now CallSetup calls UnmarkGray on the passed-in object, but if we then gc while someone is using that object and while the CallSetup is on the stack, the object can go gray again.

We should just hold a Rooted to the object in the CallSetup so we don't have to worry about that stuff.
Created attachment 751767 [details] [diff] [review]
Make CallSetup hold a Rooted to the object it's constructed with so we don't have to worry about it going gray while things like argument conversion for the call are in progress.
Attachment #751767 - Flags: review?(continuation)
Assignee: nobody → bzbarsky
Comment on attachment 751767 [details] [diff] [review]
Make CallSetup hold a Rooted to the object it's constructed with so we don't have to worry about it going gray while things like argument conversion for the call are in progress.

Review of attachment 751767 [details] [diff] [review]:
-----------------------------------------------------------------

good catch
Attachment #751767 - Flags: review?(continuation) → review+
Flags: in-testsuite-
Target Milestone: --- → mozilla24
https://hg.mozilla.org/mozilla-central/rev/d3052c10db7b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.