874152 - trusted content of panel can't access 'addon' object

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Vikas Saurabh]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130511120803

Steps to reproduce:

In https://addons.mozilla.org/en-US/firefox/addon/OfflineQR/, I use 'addon' object to communicate between trusted content and main addon code.
Post FF23 (Aurora channel), the access of 'addon' object isn't working from trusted content.


Actual results:

I find following in console:
Error: ReferenceError: addon is not defined
Source File: resource://jid1-5h9we5dytuz14q-at-jetpack/offline_qr/data/htmlQR/index.html?isAddon=true
Line: 35


Expected results:

'addon' object should be accessible.

Comment 1

[Vikas Saurabh]

Bisecting mozilla/addon-sdk led to https://github.com/mozilla/addon-sdk/commit/5536d4235df0779349f1a19065b00775aeb38573 as the first commit when 'addon' object couldn't be accessed.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1005

Pointer to Github pull-request

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I fixed that regression and think we should probably uplift the change.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/007eb037f0406e9791ac179dae21411ed6663966
Merge pull request #1005 from Gozala/bug/addon-global@874152

Bug 874152 - Fix regression that removed `addon` global.

Comment 5

[Dave Townsend [:mossop]]

Attachment: aurora uplift patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 816257
User impact if declined: Some add-ons will not function correctly
Testing completed (on m-c, etc.): On m-c over the weekend, has automated tests
Risk to taking this patch (and alternatives if risky): Low risk
String or IDL/UUID changes made by this patch: None

Comment 6

[Dave Townsend [:mossop]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f56bb4acb8ba