874198 - Remove "pluginsPage" from _getPluginInfo because it is unused

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[Benjamin Smedberg]

Currently _getPluginInfo spends some effort to get the correct pluginsPage for a plugin instance. As far as I can tell, this information is unused. As part of the CtP doorhanger work I removed it, because I have other things to put in this function and it was getting confused. And removing dead code is good!

cers, you don't know of any clients of this property related to your recent PFS work, do you?

Comment 1

[John Schoenick [:johns]]

The only remaining reference to pluginsPage is in

http://dxr.mozilla.org/mozilla-central/toolkit/mozapps/plugins/content/pluginInstallerWizard.js

There was also the confusingly similar-but-different pluginUrl, removed in bug 548133

Comment 2

[John Schoenick [:johns]]

Actually, if you properly search without case sensitivity, we normalize this URL in nsPluginInstanceOwner::FixUpURLS for some reason. (This probably wont survive bug 853995)

Comment 3

[Benjamin Smedberg]

Attachment: remove _pluginsPage, rev. 1

I didn't search far enough afield ;-) I think we can safely break pluginsPage in the PFS UI right now, if that's ok.

Comment 4

[Christian Sonne [:cers]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #0)
> cers, you don't know of any clients of this property related to your recent
> PFS work, do you?

At least after bug 836420, I'm quite certain it's not used anywhere.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

I think it'd be safer to wait until bug 836420 is fixed.

Comment 6

[Benjamin Smedberg]

When will that be done? I've got a bunch of work sitting on top of this that has to make Fx24.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 752195 [details] [diff] [review]
remove _pluginsPage, rev. 1

Review of attachment 752195 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think PFS is going to be removed in Fx24. Dolske, are you OK with breaking this part of the PFS UI?

Comment 8

[Justin Dolske [:Dolske]]

Comment on attachment 752195 [details] [diff] [review]
remove _pluginsPage, rev. 1

Review of attachment 752195 [details] [diff] [review]:
-----------------------------------------------------------------

bye-bye!

I suppose we could nuke the usage in pluginInstallerWizard.js too, but that code is already old and nasty and should just die.

Comment 10

[Jesse Ruderman]

Oh, bug 655916 is already fixed? Awesome.

Comment 11

[Benjamin Smedberg]

This landed rolled up with other CtP patches.