874213 - DeviceStorage: Add a .default attribute to the device storage object.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Dave Hylands [:dhylands]]

As per our conversation on the Dev-B2G list, this bug is to add a .default attribute to the device storage object.

This would reflect which device storage object would be chosen as the default object when new files are saved using the composite device storage object.

The attribute only makes sense on real device storage abjects, and only one real device storage object (within a type) can have the attribute at a time.

I'd further propose that setting the attribute to true should change the indicated storage object to be the default one (which is now done through the settings app).

I'd also propose that trying to read or write this attribue on the composite object should throw an error (from the JS perspective). Querying the attribute on any non-composite device storage object would return true or false.

Comment 1

[Dave Hylands [:dhylands]]

I'm nominating for leo+ since the leo devices are the first devices to have multiple storage areas, and they're the ones which would benefit from having this attribute available.

Adding the .default attribute is essentially trivial.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I think this is needed in order to enable 3rd party apps to build good UIs when it comes to allowing the user to choose where a given picture or other file should be saved. I.e. if it should be saved in internal storage or on the sdcard.

Comment 3

[Alex Keybl [:akeybl]]

In support of a new v1.1 device, and Dave/Jonas' recommendations, we'll block.

Comment 4

[Dave Hylands [:dhylands]]

Attachment: Add .default attribute to the device storage object

Comment 5

[Dave Hylands [:dhylands]]

Comment on attachment 757408 [details] [diff] [review]
Add .default attribute to the device storage object

A small patch that needs review (hopefully by tomorow)

Comment 6

[Jan Varga [:janv]]

Comment on attachment 757408 [details] [diff] [review]
Add .default attribute to the device storage object

Review of attachment 757408 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

Comment 7

[Dave Hylands [:dhylands]]

https://hg.mozilla.org/projects/birch/rev/a40105015f6d

Comment 8

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/a40105015f6d

Comment 9

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/b6f9eab044dd
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/b6f9eab044dd

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Is this supposed to expose anything to JS on m-c, and if so, did you test that?

Comment 11

[Dave Hylands [:dhylands]]

Yes it does and yes I did.

I have an app called ds-test which I used to test it on a leo device (the only device we currently have which has multiple storage areas).

Comment 12

[Jean-Yves Perrier [:teoli]]

Documentation:
https://developer.mozilla.org/en-US/docs/Web/API/DeviceStorage.default