874286 - implement query syntax parsing

Status: RESOLVED FIXED

(Input Graveyard :: Search, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Currently we're doing a text, text_phrase and fuzzy search on the description field along with some filters on created, happy, locale and platform.

We should add support for more advanced query syntax.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

We could write a query parser which parses the search text and assembles the Elasticsearch query clauses.

Maybe base the syntax on Google search syntax?:

* query OR query
* query AND query
* "query phrase"

https://support.google.com/websearch/answer/136861?hl=en

I'm not a user of Input, so I don't know what the needs are. Is this syntax ok? What else should be supported?

Comment 2

[[:Cww]]

This is fine. I don't know what other options are but that sounds good.  I'd like to be able to do "query phrase" AND query but I assume that's the case.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/113

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master:

https://github.com/mozilla/fjord/commit/c78efdd
https://github.com/mozilla/fjord/commit/c59d53d
https://github.com/mozilla/fjord/commit/5e0a983
https://github.com/mozilla/fjord/commit/af13d62
https://github.com/mozilla/fjord/commit/bf97583
https://github.com/mozilla/fjord/commit/20199e7

This is on stage now:

https://input.allizom.org/en-US/?q=ffs+OR+%22private+browsing%22&date_end=2013-05-29&date_start=2013-02-28&page=1

Cheng: Do you want to spend some time with it on stage or should I just push it to master now?

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

I didn't hear anything from Cheng and I was running out of time, so I pushed it to prod just now.

Comment 6

[[:Cww]]

Sorry, missed the bug ping. This looks great.