874305 - Support GStreamer < 0.10.31

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: Fix

Comment 2

[Alessandro Decina]

Comment on attachment 751970 [details] [diff] [review]
Fix

Review of attachment 751970 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for working on this, there's only one change needed that I can see.

Also the patch is applied on top of the patch for https://bugzilla.mozilla.org/show_bug.cgi?id=859199, so you should either land that one first or make it independent.

::: content/media/gstreamer/GStreamerFormatHelper.cpp
@@ +221,5 @@
> +      if (SupportsCaps(GST_ELEMENT_FACTORY_CAST(elem->data), caps)) {
> +        gst_caps_unref(caps);
> +        return true;
> +      }
> +    }

this should be if (!SupportedCaps(...)) return false, since we want to check that we have elements to handle _all_ the caps

Comment 3

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: Fix v2

Comment 4

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de789c0f4b9a

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/de789c0f4b9a