Closed Bug 874305 Opened 8 years ago Closed 8 years ago

Support GStreamer < 0.10.31

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: eflores, Assigned: eflores)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch Fix (obsolete) — Splinter Review
Assignee: nobody → edwin
Status: NEW → ASSIGNED
Attachment #751970 - Flags: review?(alessandro.d)
Comment on attachment 751970 [details] [diff] [review]
Fix

Review of attachment 751970 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for working on this, there's only one change needed that I can see.

Also the patch is applied on top of the patch for https://bugzilla.mozilla.org/show_bug.cgi?id=859199, so you should either land that one first or make it independent.

::: content/media/gstreamer/GStreamerFormatHelper.cpp
@@ +221,5 @@
> +      if (SupportsCaps(GST_ELEMENT_FACTORY_CAST(elem->data), caps)) {
> +        gst_caps_unref(caps);
> +        return true;
> +      }
> +    }

this should be if (!SupportedCaps(...)) return false, since we want to check that we have elements to handle _all_ the caps
Attachment #751970 - Flags: review?(alessandro.d) → review-
Attached patch Fix v2Splinter Review
Attachment #751970 - Attachment is obsolete: true
Attachment #757759 - Flags: review?(alessandro.d)
Attachment #757759 - Flags: review?(alessandro.d) → review+
https://hg.mozilla.org/mozilla-central/rev/de789c0f4b9a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.