874448 - OS X customization mode doesn't have dragover border indicators on toolbarpaletteitems

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[:Gijs (he/him)]

This makes it hard to tell where items will end up when dragging them.

Comment 1

[:Gijs (he/him)]

Attachment: Patch

This is all that's needed, AFAICT.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 752194 [details] [diff] [review]
Patch

Can you describe what exactly is broken here and how this patch fixes it? It's not obvious to me at a first glance.

Comment 3

[:Gijs (he/him)]

On Windows/Linux, when you drag an item over a toolbar item in customization mode, the item gets a dragover attribute with value 'left' or 'right' depending on LTR/RTL, and a 2px black border appears indicating where the item you're dragging would end up if you dropped it at that point.

On OS X, this border currently doesn't appear. There's styling for this border a while further down in the file: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/toolbar.css#96

but because the margin/border "exchanges" in the patch *aren't* yet in the file like they are on Windows/Linux, that rule currently ends up doing nothing (the toolbarpaletteitems have no border). Hence the patch.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 752194 [details] [diff] [review]
Patch

This should probably be moved down into the "drag and drop feedback" section for clarity.

Comment 5

[:Gijs (he/him)]

(In reply to Dão Gottwald [:dao] from comment #4)
> Comment on attachment 752194 [details] [diff] [review]
> Patch
> 
> This should probably be moved down into the "drag and drop feedback" section
> for clarity.

OK. Would you want me to move the blocks in the linux/windows copies as well, or leave those for hg annotate/blame reasons?

Comment 6

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch from comment #5)
> (In reply to Dão Gottwald [:dao] from comment #4)
> > Comment on attachment 752194 [details] [diff] [review]
> > Patch
> > 
> > This should probably be moved down into the "drag and drop feedback" section
> > for clarity.
> 
> OK. Would you want me to move the blocks in the linux/windows copies as
> well, or leave those for hg annotate/blame reasons?

I'd prefer if they were moved there as well.

Comment 7

[:Gijs (he/him)]

Cool, pushed to UX with the blocks moved everywhere: https://hg.mozilla.org/projects/ux/rev/daf6a4427453

Comment 8

[Dão Gottwald [:dao]]

Any reason why this shouldn't land on mozilla-central today?

Comment 9

[:Gijs (he/him)]

(In reply to Dão Gottwald [:dao] from comment #8)
> Any reason why this shouldn't land on mozilla-central today?

I guess not. Should I just push this to inbound then?

Comment 10

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch from comment #9)
> (In reply to Dão Gottwald [:dao] from comment #8)
> > Any reason why this shouldn't land on mozilla-central today?
> 
> I guess not. Should I just push this to inbound then?

yep

Comment 11

[:Gijs (he/him)]

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/b3389f3d96fc

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b3389f3d96fc

Comment 13

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/daf6a4427453