874484 - Timeout for remote debugging / adbd

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Christiane Ruetten [INACTIVE]]

We identified remote debugging as vector for several security threats. A simple mitigation to all of the connected risks is to introduce a timeout (I suggest something between 8 and 24 hours; 12h seems sensible) after which remote debugging automatically turns off until it is manually activated on the phone again.

This should land as soon as possible, because it is powerful, easy to implement and other mitigations will take much longer.

Comment 1

[Paul Theriault [:pauljt] (no longer reading bugmail)]

Another option or additional control would be to add some kind of visible indicator that the phone is in debug mode (e.g. bar at top of screen, or persistent notification etc)

Comment 2

[Dave Hylands [:dhylands]]

Attachment: Disables ADB after a timeout (when marionette is disabled)

This patch causes ADB to automatically be disabled after 12 hours on builds where marionette is disabled (i.e. production builds).

Comment 3

[Dave Hylands [:dhylands]]

Attachment: Disables ADB after a timeout (when marionette is disabled) v2

Fixed default value in b2g.js

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 791012 [details] [diff] [review]
Disables ADB after a timeout (when marionette is disabled) v2

Review of attachment 791012 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

::: b2g/app/b2g.js
@@ +748,5 @@
>  pref("dom.promise.enabled", false);
>  
> +// Allow ADB to run for this many milliseconds before disabling
> +// (only applies when marionette is disabled)
> +pref("b2g.adb.timeout", 12 * 60 * 60 * 1000);  // 12 hours

I would rather just specify the number of hours here, and do the conversion to milliseconds in settings.js

Comment 5

[Dave Hylands [:dhylands]]

https://hg.mozilla.org/integration/b2g-inbound/rev/12196310221f

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/12196310221f

Comment 7

[bhavana bajaj [:bajaj]]

Should already be in 1.2, clearing the koi nom, here.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Comment on attachment 791012 [details] [diff] [review]
Disables ADB after a timeout (when marionette is disabled) v2

It's not in Aurora, and webqa needs this pushed to aurora because it's causing issues with automation:
http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/file/4fbe1b01ed63/b2g/app/b2g.js#l786

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Oops.  made a mistake it is in the build, the timing was moved over to hours.  Please ignore last comment.