874505 - Alias PluginContentURL->URL and PluginUserComment->Comments in the processor

Status: RESOLVED FIXED

(Socorro :: Backend, task)

Description

[Benjamin Smedberg]

In bug 648675 we added plugin URLs and comments. For accident-of-history reasons, those are not sent with "URL" and "Comments" keys, but rather "PluginContentURL" and "PluginUserComment".

Can you please change the collector and/or processor to alias these together so that in postgres and therefore the frontend they use the existing URL and Comments fields?

This code is in Firefox 21, so if it's not too hard to do, I'd like this in a release soon so that everyone (especially the triagers, scoobidiver and alice) can see the comments?

Comment 1

[K Lars Lohn [:lars] [:klohn]]

I believe we can do this with the Processor's rewrite rules.  If so, then we need no code changes.  We'll just need add a couple lines to a table in Postgres...  I'll investigate and report back.

Comment 2

[K Lars Lohn [:lars] [:klohn]]

No joy.  I have to add a minor amount of code to accomplish this task.  

github PR 1257 covers this change:  https://github.com/mozilla/socorro/pull/1257

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/269e437e3a5de08923226a6616eb12736ef64666
Merge pull request #1257 from twobraids/other-rewrite

Fixes Bug 874505 - added new rule to copy Plugin url and comment...

Comment 4

[K Lars Lohn [:lars] [:klohn]]

Attachment: test crash

this attachment is a crash that will trigger both of the rewrite transform rules in this bug.  After processing this crash from the perspective of the UI, the "URL" should contain "https://wc-fb-vip.sjc.kixeye.com/canvas/?fb_source=bookmark_apps&ref=bookmarks&count=0&fb_bmpos=2_0#"  and the "User Comments" field should contain "this is a bogus comment"

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/05d1294e43f8feccda23742971abd1a5976e07a7
Remove unused rule predicates and actions

transform_rules had a section for 'useful rule predicates and actions' dating back 5 years. Only one of the methods was referenced outside of testing the methods directly. That reference is implicit, in an alembic migration as the fully qualified path to the method. We no longer use postgres for storing rulesets. I did some archeology to PR 1257 and bug 874505, and can confirm there are rules in the current architecture that implement this functionality without using the DB or referencing these specific methods.