874600 - <input type=file> has unreadable text on dark/black background now

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[j.j.]

See attachment 180720 [details]: Text on input field is not readable (black on black)

Comment 1

[j.j.]

To the very least the color should be inherited.
See https://bugs.webkit.org/show_bug.cgi?id=67368

Compare upcoming testcase with WebKit/Chrome

Comment 2

[j.j.]

Attachment: testcase

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Patch

Nice catch, thanks :)

Comment 4

[Mounir Lamouri (:mounir)]

Try: https://tbpl.mozilla.org/?tree=Try&rev=bced1c25b398

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 752777 [details] [diff] [review]
Patch

r=me

Comment 6

[Mounir Lamouri (:mounir)]

Thank you for this quick review Boris.

https://hg.mozilla.org/integration/mozilla-inbound/rev/18f85a091e65

Comment 7

[Mounir Lamouri (:mounir)]

Comment on attachment 752777 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 874600
User impact if declined: some text might be hardly readable but this bug is affecting old versions of Webkit (Safari 5 and multiple versions of Safari Mobile).
Testing completed (on m-c, etc.): automated tests
Risk to taking this patch (and alternatives if risky): the risk is very low, the benefit isn't high too (given that it's only a disagreement, not terrible) but given that there is barely no risk and that the patch is very small and affects limited part of the code (one CSS line), it seems to me worth to take this patch.

Comment 8

[Mounir Lamouri (:mounir)]

(In reply to Mounir Lamouri (:mounir) from comment #7)
> Comment on attachment 752777 [details] [diff] [review]
> Patch
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): bug 874600

I meant bug 52500.

Comment 9

[j.j.]

(In reply to Mounir Lamouri (:mounir) from comment #7)
> User impact if declined: some text might be hardly readable but this bug is
> affecting old versions of Webkit (Safari 5 and multiple versions of Safari
> Mobile).

... but people work around it with -webkit- pseudo-elements

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/18f85a091e65

Comment 11

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7254baf1c150
https://hg.mozilla.org/releases/mozilla-beta/rev/681cb8fbd527

Comment 12

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20100101 Firefox/22.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:22.0) Gecko/20100101 Firefox/22.0
Mozilla/5.0 (Windows NT 6.1; rv:22.0) Gecko/20100101 Firefox/22.0
Build ID: 20130528181031

Verified the fix on latest Firefox 22 beta 3 builds.