874607 - [newsletter] Adding Language & HTML parameters to /confirm to trigger welcome email

Status: VERIFIED FIXED

(www.mozilla.org :: Newsletters, defect)

Description

[Jessilyn Davis]

When someone lands on www.mozilla.org/newsletter/confirm/TOKEN , basket should look at the following flags:

LANGUAGE_ISO2
EMAIL_FORMAT_
FIREFOX_OS_FLG  (If N or blank, look for MOZILLA_AND_YOU_FLG = Y)

Comment 1

[Jessilyn Davis]

(Sorry hit "Enter" and instead of a Paragraph break, it saved the changes)

After basket checks those fields in Exact Target, the corresponding Welcome email should be sent:

Language(2)_Name_of_Trigger_EmailFormat


for example:

ES_FirefoxOS_Welcome_H

or

PT_FirefoxOS_Welcome_T


*Note: Language is only 2 characters (PT or ES), not 5 (pt-BR or es-ES)

Comment 2

[Dan Poirier [:dpoirier]]

That's about what I had, only we were not putting "_H" on the HTML format welcomes.  So HTML welcome would be ES_FirefoxOS_Welcome, text would be ES_FirefoxOS_Welcome_T.

Comment 3

[Jessilyn Davis]

Ah - great catch. The naming will be as Dan says:

ES_FirefoxOS_Welcome
ES_FirefoxOS_Welcome_T

Comment 4

[Rebecca Billings [:rbillings]]

Verified language and html/text options

Comment 5

[Dan Poirier [:dpoirier]]

Update on the welcome message naming - we ended up changing to use the language code in lowercase, to be consistent with other uses of language codes.  So we'd have:

es_FirefoxOS_Welcome
es_FirefoxOS_Welcome_T

Comment 6

[Dan Poirier [:dpoirier]]

Another update on the welcome message naming - we are always going to prepend the language code + "_", for consistency. All together the algorithm is:

- Get the welcome ID from the newsletter's entry in basket. Call it WELCOME.
- If it's blank or just spaces, send no welcome.
- Get the first two chars of the user's preferred language. Lowercase and call that 'langcode'.
- Get the first two chars of each language supported by the newsletter and lowercase.
- If the user's lang code is not in the list of newsletter lang codes, change langcode to 'en'.
- If the user prefers Text, the final welcome is langcode_WELCOME_T.
- Otherwise, the final welcome is langcode_WELCOME.

Comment 7

[Jessilyn Davis]

All emails have new triggers with the proper naming convention (ie "en_Firefox_Flicks_welcome"; "en_39")

To test:

1) https://www-dev.allizom.org/en-US/firefox/fx/
Bedrock test; signup for en-US, make sure and get pretty new welcome

Rbillings tested = great

2) https://www-dev.allizom.org/en-US/firefox/fx/
Bedrock l10n test; sign up for fr, get confirmation email, confirm, and you should get no welcome email at this time (there will be an error in sentry that fr_fxandyouwelcome doesn't exist in ET - which it doesn't until it's been localized and created)

3) https://www-dev.allizom.org/fr/firefox/fx/
php l10n site test
Sign up for en-US in footer, get new pretty welcome email


4) https://www-dev.allizom.org/fr/firefox/fx/
php l10n test
Sign up for en-US in footer, get new pretty welcome email
added to master subscribers with just "MOZILLA_AND_YOU_FLG"

5.1) https://www-dev.allizom.org/en-US/newsletter
signup for en-US, make sure and get pretty new welcome


5.2) on next page (https://www-dev.allizom.org/en-US/newsletter) - sign up for several other newsletters and submit. Make sure you don't get new welcomes.

6) https://www-dev.allizom.org/l10n/newsletter
php test; signup for non en-US, get confirmation email, confirm, make sure don't get new email

7) Multiple newsletter + welcome test
http://www.mozilla.org/en-US/contribute/universityambassadors/
Sign up for multiple newsletters & make sure it shows up in Master Subscribers
You should get Student Ambassadors email
If you signed up for FFx & You - you might get that welcome email (let me know)
If you signed up for Firefox for Android and FFx & you - make sure you only get the new pretty firefox & you welcome once. not twice.
If you signed up for Flicks - you might get that welcome email too (let me know)
If you signed up for about:mozilla - you shouldn't get a welcome email (make sure it's not the old "mozilla and you" newsletter design)

8) Multiple newsletter + welcome test take 2
https://www.mozilla.org/en-US/firefox/beta/

signup for more than one newsletter and see what happens
If you sign up for Firefox & You - you should get the pretty welcome email - not the old "mozilla & you" email too

If you sign up for only beta, or only aurora, or beta + aurora = no welcome should be sent.

Make sure people are passed through to Master_Subscribers with the right fields

Comment 8

[Jessilyn Davis]

9) Make sure we didn't break Affiliates  -> pmac is there a way we can test this on dev?

sign up for affilates in the en-US locale, and check the box for the newsletter upon signup. make sure you're added to master subscribers with right flags, and you get the affiliates welcome.

Comment 9

[Jessilyn Davis]

rbillings is going to test early tomorrow am - I'll see if I can do some tomorrow am too to help out if she needs/wants me.

We'll have a status by our 10am PDT checkin tomorrow.

Thanks all!

Comment 10

[Jessilyn Davis]

> 7) Multiple newsletter + welcome test
> http://www.mozilla.org/en-US/contribute/universityambassadors/
> Sign up for multiple newsletters & make sure it shows up in Master
> Subscribers
> You should get Student Ambassadors email
> If you signed up for FFx & You - you might get that welcome email (let me
> know)
> If you signed up for Firefox for Android and FFx & you - make sure you only
> get the new pretty firefox & you welcome once. not twice.
> If you signed up for Flicks - you might get that welcome email too (let me
> know)
> If you signed up for about:mozilla - you shouldn't get a welcome email (make
> sure it's not the old "mozilla and you" newsletter design)

Signed up person for all available newsletters and was added to Master_Subscribers successfully.

Error found:
Didn't get ANY welcomes.

Expected behavior:
To receive each of these once:
en_Student_Ambassadors_Welcome
en_fxandyou_Welcome (1 - not 2 even though i have both Fx&you AND mobile/android)
en_Firefox_Flicks_Welcome

To not receive:
en_39 (which might have happened b/c I subscribed to about mozilla who's welcome email is blank)


dan & pmac, can you check first thing your time so that hopefully rbillings and i can test when we sign-on?

Comment 11

[Jessilyn Davis]

5.2) on next page (https://www-dev.allizom.org/en-US/newsletter/new) - sign up for several other newsletters and submit. Make sure you don't get new welcomes.

5.3) go to email preference center for existing subscriber in Master Subscribers (ie from one of the en-US welcome emails) and subscribe to Flicks
Make sure your flags update in ET, and that you do NOT get a welcome email.

Comment 12

[Dan Poirier [:dpoirier]]

Found two things:

1) Bug in basket. pmac can you review https://github.com/mozilla/basket/pull/60 ?  This would have broken welcomes completely on new users coming from forms that didn't ask for language. Apparently student ambassadors is one of those?  

2) Saw this error in Sentry indicating it tried to send 'fr_fxandyou_Welcome' but there isn't one. I'm not sure if you were expecting that to work or not: 

BasketError: send_message(u'fr_fxandyou_Welcome', [e-mail], db09cf3b-d694-40f8-93c5-da90075d2ffd, H): No such message ID: u'fr_fxandyou_Welcome' (Invalid Customer Key)

Comment 13

[Jessilyn Davis]

> 1) Bug in basket. pmac can you review
> https://github.com/mozilla/basket/pull/60 ?  This would have broken welcomes
> completely on new users coming from forms that didn't ask for language.
> Apparently student ambassadors is one of those?  

Correct. And the en-US/newsletter (old php site) is one as well. And the beta signup form.

> 2) Saw this error in Sentry indicating it tried to send
> 'fr_fxandyou_Welcome' but there isn't one. I'm not sure if you were
> expecting that to work or not: 
> 
> BasketError: send_message(u'fr_fxandyou_Welcome',
> [e-mail], db09cf3b-d694-40f8-93c5-da90075d2ffd, H): No
> such message ID: u'fr_fxandyou_Welcome' (Invalid Customer Key)


Correct. These are the new Firefox & You welcome emails that I don't have localized and setup yet. We'll keep getting these errors until I can get the copy localized and the email setup. Would it be good to create a rule for these (and the other non-en locales) so that it doesn't fill your error logs?

Thanks Dan!

Pmac, let us know when the pull request has been reviewed and merged. Thanks!

Comment 14

[Dan Poirier [:dpoirier]]

(In reply to Jessilyn Davis from comment #13)
> Pmac, let us know when the pull request has been reviewed and merged. Thanks!

I'm not pmac, but the PR has been reviewed and merged and should be live on basket-dev.

Comment 15

[Jessilyn Davis]

rbillings has confirmed that all testing scenarios above work great on dev.

We're almost there!

Last tests:

1) Make sure l10n FFx & You signup works with confirm + welcome email
Go to: https://www-dev.allizom.org/ru/newsletter
Sign up with new contact for RU news
Confirm
Make sure you get Firefox & You welcome email in RU


2) Make sure FFx & You l10n confirm process sends 1 welcome and not 2
Go to demo 2 OS signup form
Sign up in Russian (with new subscriber)
Confirm signup
Make sure you get just the new OS welcome in RU (not the reg. Firefox & You welcome)


3) Make sure FFx & You + OS en signup sends 1 welcome and not 2
Go to demo 2 OS signup form
Sign up in English (with new subscriber)
Make sure you get just the new OS welcome in en (not the reg. Firefox & You welcome)


4) Make sure l10n /existing page (in php) works properly
Have en subscriber subscribed only to FFx & You
Go to their email pref center
Change URL to be non-EN
Change language of subscriber to non-EN and subscribe to Android newsletter
Make sure changes took effect in Master Subscribers and in /existing page for that subscriber (change language and new subscription flag) - and make sure no welcome emails were sent.

Comment 16

[Rebecca Billings [:rbillings]]

Verified everything in comment 7*, and comment 15. I also checked Affiliates on dev with a new persona. All changes double checked in Master_Subscribers & Double_Opt_In.

* For Step 7 Emails received: Ambassadors, FF & You, Flicks
* For Step 8 Emails received: FF & You

Comment 17

[Jessilyn Davis]

Awesome - we're ready for push!

Bug 887429  is for the push :D

Comment 18

[Jessilyn Davis]

Another scenario to test when this goes live (and it just tested it on dev and it worked!

1) Test duplicate fix + welcome email for Firefox & you
Sign up for en newsletter that's not Firefox & You
Confirm you're in Master Subscribers
Go to /ru/newsletter and signup for the Russian newsletter
Make sure you get the Russian Firefox & You welcome email (in the right format)

Comment 19

[Rebecca Billings [:rbillings]]

Getting duplicate emails for beta subscriptions: https://www.allizom.org/en-US/firefox/beta

Comment 20

[Jessilyn Davis]

Stage looks good now! ready for prod

Comment 21

[Jessilyn Davis]

Tested and went live with today's push! :D

Comment 22

[Rebecca Billings [:rbillings]]

Verified on prod